Feature #2700
closed
Bulk move users to a different work position and change their contract expiration
100%
Description
- Select identities
- Select if the work position should be changed - if so, select its new value
- Select if the contract validity should be changed - if so, select its new value
- Run
- All contracts of the identities will be changed according to the selection. (Note: moving to the new work position must recalculate the automatic roles by tree nodes)
The permissions should behave as in #2664 - if an identity has multiple contracts and the current user can't edit all, then the change should take place only for the editable contracts.
Related issues
Updated by Radek Tomiška almost 4 years ago
- Assignee changed from Radek Tomiška to Ondrej Husník
- Estimated time set to 16.00 h
Updated by Ondrej Husník almost 4 years ago
- Status changed from New to In Progress
Updated by Ondrej Husník almost 4 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
- % Done changed from 0 to 90
This bulk action implements setting of the new work position and validity dates for user's contracts. There is small divergence in using this BA from regular usage on the contract detail. The thing is that if no value is selected, corresponding item is not changed unlike setting empty value which can be performed on standard detail. Therefore this BA is not able to set unlimited contract validity or no contract position. This limitation will be removed in future.
Please could you do me a feedback?
https://github.com/bcvsolutions/CzechIdMng/commit/1bb49e316051b12d8e7c375998b1895af6a564f3
some doc:
https://wiki.czechidm.com/tutorial/adm/identities_bulk_actions#change_contract_validity_and_position
Updated by Radek Tomiška over 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 90 to 100
I did test and code review, it works, thx.
Review notes:
- we are not using abbreviations
- unnecessary tree node loading removed
- placeholder for inputs added
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/29d81d2457e5c118a5c1d076fd1dea7a6bca9f5e
Updated by Radek Tomiška over 3 years ago
- Status changed from Resolved to In Progress
- % Done changed from 100 to 80
I found an issue: Bulk action is process even for contracts, which are controlled by contract time slices. Contract controlled by cntract slices cannot be changed directly.
Updated by Radek Tomiška over 3 years ago
- Related to Defect #2771: Contracts controlled by time slices shouldn't be updated through form projection added
Updated by Radek Tomiška over 3 years ago
- Related to Defect #2753: Contract slices: Contract guarantee can be added / deleted when contract is controlled by slices added
Updated by Ondrej Husník over 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
Beside main task of this ticket there was also implemented BE parts of preventing from contract modification when contract is controlled by time slice.
Please, could you provide me feedback?
https://github.com/bcvsolutions/CzechIdMng/commit/b1577cc2cd2bde95c992a885dd01bf8921382d3a
Updated by Radek Tomiška over 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 80 to 100
I did test and review, it works, thx. This check will help on every place in application, nice.
Review notes:
- count method is used to prevent load all slices for check
- event content cannot be null
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/7251036d9fe204a9b2003a4db061ed2e1e9e0594
Updated by Radek Tomiška over 3 years ago
- Status changed from Resolved to Closed
Updated by Radek Tomiška about 3 years ago
- Related to Defect #2990: Some bulk actions started by managers process more users/contracts than they should added