Project

General

Profile

Actions

Defect #2771

closed

Contracts controlled by time slices shouldn't be updated through form projection

Added by Alena Peterová almost 3 years ago. Updated almost 3 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Start date:
04/20/2021
Due date:
% Done:

100%

Estimated time:

Description

Tested on 10.8.2, ultra low priority.
We have identities with contracts controlled by time slices. When we set a form projection to the users and check "Show prime contract", then we can change attributes of the contract through this projection. It can't be changed through the full detail, so it shouldn't be possible to change by the form projection.


Related issues

Related to IdStory Identity Manager - Feature #2700: Bulk move users to a different work position and change their contract expirationClosedOndrej Husník03/02/2021

Actions
Related to IdStory Identity Manager - Defect #2844: Form projection allows edit contract controlled by time slicesRejectedOndrej Husník05/31/2021

Actions
Actions #1

Updated by Alena Peterová almost 3 years ago

  • Subject changed from Contracts controlled by time slices may be changed through form projection to Contracts controlled by time slices shouldn't be updated through form projection
  • Description updated (diff)
Actions #2

Updated by Radek Tomiška almost 3 years ago

  • Assignee changed from Radek Tomiška to Ondrej Husník
Actions #3

Updated by Radek Tomiška almost 3 years ago

  • Related to Feature #2700: Bulk move users to a different work position and change their contract expiration added
Actions #4

Updated by Radek Tomiška almost 3 years ago

  • Status changed from New to In Progress
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • Target version set to 11.0.0
Actions #5

Updated by Radek Tomiška almost 3 years ago

  • Tracker changed from Task to Defect
  • Affected versions 10.2.0, 10.3.0, 10.3.1, 10.3.2, 10.3.3, 10.4.0, 10.4.1, 10.4.2, 10.4.3, 10.4.4, 10.5.0, 10.5.1, 10.4.5, 10.4.6, 10.4.7, 10.5.2, 10.5.3, 10.4.8, 10.6.0, 10.4.9, 10.5.4, 10.6.1, 10.6.2, 10.6.3, 10.6.4, 10.7.0, 10.7.1, 10.6.5, 10.7.2, 10.6.6, 10.8.0, 10.8.1, 10.8.3, 10.8.2, 10.8.4 added
Actions #6

Updated by Radek Tomiška almost 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 0 to 90

Contracts are disabled in projection on FE, when they are controlled by contract slices.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/4c242ac13d38c567537542d7c31ae598cebcdf10

Could you please provide me a feedback?

Note: BE validation will be implemented in related #2700.

Actions #7

Updated by Radek Tomiška almost 3 years ago

I've added support for saving other positions for contract controlled with slices in projection:
https://github.com/bcvsolutions/CzechIdMng/commit/7ee2d1ec8a4286dbcc3c83ee8f68b0d5ce61c2b0
and prevent delete contract controlled by slices:
https://github.com/bcvsolutions/CzechIdMng/commit/8763c3bfa5ce22b3e0a3a94b835c90806b2d1248

Note: Sorry for additional commits.

Actions #8

Updated by Ondrej Husník almost 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 90 to 100

Looks good. Contract controlled by slice is read-only whereas non-controlled contract is still editable form projection.

Actions #9

Updated by Radek Tomiška almost 3 years ago

  • Status changed from Resolved to Closed
Actions #10

Updated by Radek Tomiška almost 3 years ago

  • Related to Defect #2844: Form projection allows edit contract controlled by time slices added
Actions

Also available in: Atom PDF