Project

General

Profile

Feature #2664

Bulk add and remove contract manager

Added by Vladimír Kotýnek 3 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
High
Category:
Bulk operations
Target version:
Start date:
01/26/2021
Due date:
02/23/2021
% Done:

100%

Estimated time:
Milestones:

Description

Create two new bulk actions on Identities.
1) Bulk add new direct manager to identity contracts
  1. Select identities
  2. Select bulk action
  3. Select identity to be set as a direct manager - only valid identity can be selected
  4. run

The bulk action will add this identity as a direct manager to all contracts if not already set.

2) Bulk remove direct manager from identity contracts
  1. select identities
  2. select bulk action
  3. select identity to be removed from direct managers - both valid and disabled identities can be selected
  4. run

The bulk action will remove this identity from direct managers of all contracts of selected identities.

Possible third LRT will replace direct manager.
3) Bulk replace direct manager
  1. select identities
  2. select bulk action
  3. select identity of existing direct manager you want to replace - "original manager"
  4. select identity of new direct manager you want to set - only valid identity can be selected - "new manager"
  5. run

The bulk action will check if the selected identity has the "original manager" set as direct manager of any contract. If so it removes the direct manager and sets "new manager" as direct manager. Otherwise it skips the contract and do nothing with it's managers. So if the identity didn't have the "original manager" set as a direct manager before the bulk action the "new manager" will not be set as it's direct manager.

History

#3 Updated by Vít Švanda 3 months ago

  • Assignee changed from Radek Tomiška to Ondrej Husník
  • Target version set to 10.8.0

#4 Updated by Vít Švanda 2 months ago

  • Target version changed from 10.8.0 to 11.0.0

#5 Updated by Vít Švanda 2 months ago

  • Due date set to 02/23/2021
  • Status changed from New to In Progress
  • Target version changed from 11.0.0 to 10.8.0

#6 Updated by Vít Švanda 2 months ago

  • Priority changed from Normal to High

#7 Updated by Ondrej Husník about 2 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 0 to 80

I implemented in this ticket 3 separate bulk actions for adding, removing and changing contract guarantee. Bulk actions are applied on all contracts of selected identities. If user running BA is not able (lack of permissions) to create or remove a guarantee for particular contract, this fact is logged into LRT log items. BA Add and Remove are able to select multiple guarantees for adding/removing. BA Change allows to change only one guarantee for another.

Here is original commit with implementation:
https://github.com/bcvsolutions/CzechIdMng/commit/b4c269fc02500b4c10f1a87e5a2e2fea42c0ec46
here is another commit with added tests of operation with missing permissions.
https://github.com/bcvsolutions/CzechIdMng/commit/31d1939d5db1afb2094a0bfc0d2270d724cb42b5
Documentation will be added.
Please could you provide me a feedback? Thank you.

#8 Updated by Radek Tomiška about 2 months ago

  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 80 to 90

I did test and code review, it works, thx! I like permission usage, bulk action icons are nice!

Review notes:
- I used update method to change guarantee (=> provisioning olny once, better message in action logs, the same behavior as from FE)
- I removed logs for identities, which are iterated only
- I removed required IDENTITY_COUNT permission - it's not needed for this actions
- I added ContractGuaranteeInfo component - visible in logs (add, update)
- parameter converter can be used for get bulk action properties
- toString is called automatically in logs
- improved positions for icons (missing padding in bulk action detail)
- we don't use abrevations
- we are using camelCase

Commits:
https://github.com/bcvsolutions/CzechIdMng/commit/3313393bb0b1d4de312709e6b1a65091ed558e8d
https://github.com/bcvsolutions/CzechIdMng/commit/e044ccc04cca9a5e9d2f5ca20aea25d753138d41

Could you please provide me feedback (and test) after my changes?

#9 Updated by Ondrej Husník about 2 months ago

Thank you for feedback and for your improvements. Especially added business card for contract guarantee improved UX.

#10 Updated by Radek Tomiška about 2 months ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 90 to 100

Thx for feedback!

#12 Updated by Radek Tomiška about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top