Defect #2753
closed
Contract slices: Contract guarantee can be added / deleted when contract is controlled by slices
100%
Description
Contract cannot be changed or removed, when contract is conntroled by time slices, but contract guarantees can be added / removed directly. When time slice is changed, then this directly changed guarantees are removed and guarantees from time slice is copied.
Note: Newly created bulk actions for contracts (IdentityAddContractGuaranteeBulkAction, IdentityChangeContractGuaranteeBulkAction, IdentityRemoveContractGuaranteeBulkAction) needs to be fixed the same way.
Related issues
Updated by Radek Tomiška about 3 years ago
- Related to Task #1067: Time slices of contracts - forward account management added
Updated by Vít Švanda about 3 years ago
- Assignee changed from Vít Švanda to Ondrej Husník
- Target version set to 11.1.0
Updated by Radek Tomiška about 3 years ago
- Related to Feature #2700: Bulk move users to a different work position and change their contract expiration added
Updated by Ondrej Husník about 3 years ago
- Status changed from New to In Progress
- Target version changed from 11.1.0 to 11.0.0
- % Done changed from 0 to 80
Updated by Ondrej Husník about 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
I also implemented BE part of this task. It can help with preventing from changing contract guarantees if contract is controlled by slice. It may be useful, because the new bulk actions for altering contract guarantees were added in the previous version.
Commited into separate branch if we decided not to put it into this version.
Please could you a provide feedback also for this task.
https://github.com/bcvsolutions/CzechIdMng/commit/56e893df1e6a81f57451c09edd563f66ad776f21
Updated by Ondrej Husník about 3 years ago
Published into develop and improved based on previous review.
https://github.com/bcvsolutions/CzechIdMng/commit/b4527ccf5367093881c88ccd03c221a51d78ea69
Small improvement is in the separate commit.
https://github.com/bcvsolutions/CzechIdMng/commit/df13c5faa5fe7e554338ac1faff1bbc6c8164a78
Updated by Radek Tomiška about 3 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 80 to 100
I did test and code review, it works and code is nice, thx!