Project

General

Profile

Actions
Copy link

Defect #3394

closed

Filtering by account in role requests doesn't work

Added by Alena Peterová over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Low
Assignee:
Peter Štrunc
Category:
Frontend
Target version:
13.0.6
Start date:
06/19/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
13.0.6
Owner:
Peter Štrunc

Description

Filtering by account in role request doesn't work

Files

Download all files
filter_by_account.png (121 KB) filter_by_account.png Alena Peterová, 06/19/2023 04:25 PM
assigned_roles_tech_account.png (93.6 KB) assigned_roles_tech_account.png Alena Peterová, 06/27/2023 05:03 PM
role_request_for_tech_account.png (47.1 KB) role_request_for_tech_account.png Alena Peterová, 06/27/2023 05:03 PM
Actions
Copy link
 #1

Updated by Peter Štrunc over 1 year ago

  • Status changed from New to Needs feedback
  • Target version set to 13.0.6
  • % Done changed from 0 to 80
  • Owner set to Peter Štrunc

Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/404

@apeterova could you check it out, please?

Actions
Copy link
 #2

Updated by Peter Štrunc over 1 year ago

  • Assignee changed from Peter Štrunc to Alena Peterová
Actions
Copy link
 #3

Updated by Alena Peterová over 1 year ago

Filtering works well for personal accounts, thanks.
However, there are errors in roles for technical accounts (I'm not sure if it was there before or not):
  • role request for tech account when selecting "Assigned to":
  • assigned roles for tech account - nonsensical filtering fields containing all users and their contracts:

Please @sourek could you check it?

Actions
Copy link
 #4

Updated by Peter Štrunc over 1 year ago

So far I was able to fix the issue on the account detail page. I will continue on the request history tomorrow. It will require a bit more tweaking

Actions
Copy link
 #5

Updated by Peter Štrunc over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Alena Peterová

I fixed both issues mentioned in the comment https://redmine.czechidm.com/issues/3394#note-3 by hiding the unnecessary select boxes in respective filters. In a new request, it was quite straightforward since the logic of determining whether it was an account or not was already there. In the request history, I had to determine the type from the applicant type so the assignment type filter is shown only for identities at the moment.

@apeterova would you please check it out again?

Actions
Copy link
 #6

Updated by Alena Peterová over 1 year ago

  • Assignee changed from Alena Peterová to Peter Štrunc

Great, please merge the pull request.

Actions
Copy link
 #7

Updated by Peter Štrunc over 1 year ago

  • Status changed from Needs feedback to Resolved
  • % Done changed from 80 to 100

Merged

Actions
Copy link
 #8

Updated by Peter Štrunc about 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF