Defect #3394
closedFiltering by account in role requests doesn't work
100%
Description
Filtering by account in role request doesn't work
Files
Updated by Peter Štrunc over 1 year ago
- Status changed from New to Needs feedback
- Target version set to 13.0.6
- % Done changed from 0 to 80
- Owner set to Peter Štrunc
Fixed here: https://github.com/bcvsolutions/CzechIdMng/pull/404
@apeterova could you check it out, please?
Updated by Peter Štrunc over 1 year ago
- Assignee changed from Peter Štrunc to Alena Peterová
Updated by Alena Peterová over 1 year ago
- File assigned_roles_tech_account.png assigned_roles_tech_account.png added
- File role_request_for_tech_account.png role_request_for_tech_account.png added
- Status changed from Needs feedback to In Progress
- Assignee changed from Alena Peterová to Peter Štrunc
However, there are errors in roles for technical accounts (I'm not sure if it was there before or not):
- role request for tech account when selecting "Assigned to":
- assigned roles for tech account - nonsensical filtering fields containing all users and their contracts:
Please @sourek could you check it?
Updated by Peter Štrunc over 1 year ago
So far I was able to fix the issue on the account detail page. I will continue on the request history tomorrow. It will require a bit more tweaking
Updated by Peter Štrunc over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Alena Peterová
I fixed both issues mentioned in the comment https://redmine.czechidm.com/issues/3394#note-3 by hiding the unnecessary select boxes in respective filters. In a new request, it was quite straightforward since the logic of determining whether it was an account or not was already there. In the request history, I had to determine the type from the applicant type so the assignment type filter is shown only for identities at the moment.
@apeterova would you please check it out again?
Updated by Alena Peterová over 1 year ago
- Assignee changed from Alena Peterová to Peter Štrunc
Great, please merge the pull request.
Updated by Peter Štrunc over 1 year ago
- Status changed from Needs feedback to Resolved
- % Done changed from 80 to 100
Merged