Feature #3164
closed
New account detail
Added by Roman Kučera almost 2 years ago. Updated about 1 year ago.
100%
Description
Use mock-ups
Detail is defined by mapping of the account
Related issues
Updated by Roman Kučera almost 2 years ago
- Blocks Feature #3163: Override values of account (FE only) added
Updated by Roman Kučera almost 2 years ago
- Blocks Feature #3150: Other account request added
Updated by Roman Kučera almost 2 years ago
- Blocks Feature #3149: Technical account request added
Updated by Tomáš Doischer almost 2 years ago
- Related to Task #2958: Confidential attributes of an user account can be displayed through accounts agenda added
Updated by Tomáš Doischer over 1 year ago
- Sprint set to Sprint 12.3-4 (zář 14 - zář 28)
- Assignee set to Roman Kučera
- Estimated time changed from 12.00 h to 24.00 h
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-4 (zář 14 - zář 28) to Sprint 12.3-5 (zář 28 - říj 12)
Updated by Roman Kučera over 1 year ago
- % Done changed from 0 to 60
implementation
https://github.com/bcvsolutions/CzechIdMng/tree/kucerar/3164-account-detail
full detail, audit, provisioning.
Read only mode, edit mode works.
Added link to account into provisioning operation and operation archive, so we can filter by it on FE.
Still some thing to fix (multivalued, all eav types, filters, ...)
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-5 (zář 28 - říj 12) to Sprint 12.3-6 (říj 12 - říj 26)
Updated by Roman Kučera over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kučera to Tomáš Doischer
- % Done changed from 60 to 80
Everything should be implemented.
Acc test passed localy, now waiting for Github action
It is based on #3150 where I'll do some changes now.
Updated by Tomáš Doischer over 1 year ago
- Related to Task #3210: Add technical account detail added
Updated by Roman Kučera over 1 year ago
Rebased onto current devel via branch 3150
Updated by Roman Kučera over 1 year ago
SQL which will perform update so provisioning archive which was created before 12.3.0 will still be available in new account detail. (If account has different identifier in the past, these operation will not be in the new detail)
UPDATE sys_provisioning_archive
SET account_id=subquery.id
FROM (SELECT id, uid, system_id, entity_type
FROM acc_account) AS subquery
WHERE sys_provisioning_archive.system_entity_uid=subquery.uid and
sys_provisioning_archive.system_id=subquery.system_id and
sys_provisioning_archive.entity_type=subquery.entity_type;
Updated by Tomáš Doischer over 1 year ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Tomáš Doischer to Roman Kučera
The new detail is super cool, thank you.
Please see the comments in the PR, I have fairly minor notes from the code review and I found some bugs during testing.
Updated by Roman Kučera over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kučera to Tomáš Doischer
Everything should be fixed and improved. thx
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-6 (říj 12 - říj 26) to Sprint 12.3-7 (říj 26 - lis 09)
Updated by Tomáš Doischer over 1 year ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Tomáš Doischer to Roman Kučera
- % Done changed from 80 to 90
Thank you for the fixes.
I'm still unable to override items that are not in the mapping - I see some BE implementation but nothing on FE.
Otherwise, this looks good and works well, thank you for the fixes.
Since #3150 is merged, can you please rebase the branch?
Updated by Roman Kučera over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Roman Kučera to Tomáš Doischer
I did rebase onto current develop.
When I test in one DB table everything is ok.
This small issue is with VS. Because for some reason, when you loading account for VS it will load based on mapping when the account was created. So when you have only mapping with one attribute you will see only one attribute on account detail. This will need some rework in VS module probably which we will do later.
When you add new attribute to mapping it displayed correctly to. If remove some attribute from mapping you will see it still on the detail so then you can override something which is no longer in mapping.
Updated by Tomáš Doischer over 1 year ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Tomáš Doischer to Roman Kučera
- % Done changed from 90 to 100
LGTM, thank you! Merged to develop.
Updated by Tomáš Doischer about 1 year ago
- Status changed from Resolved to Closed