Task #2516
closed
Add support of bulk actions for script definition
Added by Ondrej Husník over 3 years ago. Updated over 3 years ago.
100%
Description
Add support of bulk actions for script definition and implement existing actions
Related issues
Updated by Ondrej Husník over 3 years ago
- Related to Feature #2493: Allow deploy script via dropdown zone added
Updated by Tomáš Doischer over 3 years ago
One cool feature would be script duplication (similar to what you can do with systems). Create the same script but add copy to the name. It would save time with copying permissions.
It would allow you to basically use one script as a template for another one which is often useful.
Updated by Ondrej Husník over 3 years ago
- Status changed from New to In Progress
- Target version set to 10.6.0
Updated by Ondrej Husník over 3 years ago
- Related to Task #2518: Script definition duplication added
Updated by Radek Tomiška over 3 years ago
IdmScriptFilter needs to be refactored to pure DataFilter (=> fields to properties) to be able process bulk action asynchronously through LRT queue (e.g. when no thread is currently available to process bulk action).
Updated by Ondrej Husník over 3 years ago
- Related to Task #2521: Add support of bulk actions for notification templates added
Updated by Ondrej Husník over 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
Script definition agenda now supports bulk operations. The new abstract bulk actions have been created for redeployment and backup of entities, services of which implement Recoverable interface. IdmScriptFilter has also been refactored to pure DataFilter as requested.
Please provide me a feedback.
https://github.com/bcvsolutions/CzechIdMng/commit/2804a3c6e3c2d5502e8026afd02fb254f55acd14
Updated by Radek Tomiška over 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 80 to 100
I did test and code review, it works, I like super classes, prevalidation and code is clean, nice!
I did some minor review notes:
- I removed configurationService field from bulk action - is autowired in super class
- I removed field OperationResult from bulk action - is local variable only
- I removed set parameters in 'toFilter' method from controller - is not needed (data filter benefit)
- I changed order for bulk actions - order was the same as delete operation
- Prevalidate method is resused not in both bulk actions (i added info about backup folder location, even it's found)
Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/4efb7e1c75e43b6ecff1b457f18245b6a0985377
Updated by Radek Tomiška over 3 years ago
- Status changed from Resolved to Closed