Task #2518
closed
Script definition duplication
100%
Description
One cool feature would be script duplication (similar to what you can do with systems). Create the same script but add copy to the name. It would save time with copying permissions.
It would allow you to basically use one script as a template for another one which is often useful.
Related issues
Updated by Ondrej Husník over 3 years ago
- Related to Task #2516: Add support of bulk actions for script definition added
Updated by Vít Švanda over 3 years ago
- Target version changed from 10.7.0 to 10.8.0
Updated by Vít Švanda about 3 years ago
- Target version changed from 10.8.0 to 11.0.0
Updated by Radek Tomiška about 3 years ago
- Related to Feature #2533: Add download button for backup scripts and templates bulk action added
Updated by Radek Tomiška about 3 years ago
- Related to Feature #2493: Allow deploy script via dropdown zone added
Updated by Radek Tomiška about 3 years ago
- Estimated time changed from 4.00 h to 8.00 h
Updated by Ondrej Husník about 3 years ago
- Status changed from New to In Progress
Updated by Ondrej Husník about 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Vít Švanda
- % Done changed from 0 to 90
I added duplication ability for script definition.
Please could you provide me feedback. Thank you.
https://github.com/bcvsolutions/CzechIdMng/commit/305fa8e564dd1f807b6d4250c3902f2357e16fb9
Updated by Vít Švanda about 3 years ago
- Assignee changed from Vít Švanda to Radek Tomiška
Updated by Radek Tomiška about 3 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 90 to 80
I did test and code review, it works, thx!
Review notes:
- Move logic from bulk action into script service (e.g. DefaultSysSystemService) and implement CloneableService interface properly. The main benefit is @Transactional usage - when script authority creation fails, then skeleton script is created (~persisted) now.
- we are not using abbreviations
Updated by Ondrej Husník about 3 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondrej Husník to Radek Tomiška
I implemented your review recommendations. I hope that refactored code better meets your expectations.
https://github.com/bcvsolutions/CzechIdMng/commit/e13902b204b558ce750094f04442228fd65a60f9
Updated by Radek Tomiška about 3 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Radek Tomiška to Ondrej Husník
- % Done changed from 80 to 100
It's not about my expectations, it doesn't work without @Transactional usage properly and not using abbreviations is in our coding style (read please https://github.com/bcvsolutions/CzechIdMng/blob/develop/CONTRIBUTING.md#coding-style-convention).
Note: Abbreviations are still in your code (e.g. authorityFilt), but I'm closing this ticket.
Updated by Radek Tomiška almost 3 years ago
- Status changed from Resolved to Closed