Actions
Task #1755
closed
Create tests for filter workflow process definition
Start date:
07/22/2019
Due date:
% Done:
100%
Estimated time:
Owner:
Description
Service for workflow definition process (DefaultWorkflowProcessDefinitionService) has bad tests coverage. Please improve it.
- Inspiration: HistoryProcessAndTaskTest, DeployAndRunProcessTest
Updated by Artem Kolychev over 5 years ago
- Status changed from New to In Progress
Updated by Artem Kolychev over 5 years ago
- Status changed from In Progress to Needs feedback
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to In Progress
I made review. It is Ok and works. Good job.
I found some issues:- Rename the test file from "SelectTest " to "DefaultWorkflowProcessDefinitionServiceFilterTest"
- For next please add number of the redmine ticket to the description of commit ("created automatically test for selection and filtering workflow proce").
- Please remove all tests for load a diagram. We don't want have tests for expect "NullPointerException" (this situations should be fixed instead) :-).
Updated by Artem Kolychev over 5 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
https://github.com/bcvsolutions/CzechIdMng/compare/artem/1755-test-filter-processes-definitions
added new test for workflow with 3 processes
Updated by Vít Švanda over 5 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Artem Kolychev
- % Done changed from 0 to 100
It looks nice. I merged it to the develop. Thanks for that.
Updated by Artem Kolychev over 5 years ago
- Status changed from Resolved to Closed
Actions