Task #1755
closed
- Status changed from New to In Progress
- Status changed from In Progress to Needs feedback
- Status changed from Needs feedback to In Progress
I made review. It is Ok and works. Good job.
I found some issues:
- Rename the test file from "SelectTest " to "DefaultWorkflowProcessDefinitionServiceFilterTest"
- For next please add number of the redmine ticket to the description of commit ("created automatically test for selection and filtering workflow proce").
- Please remove all tests for load a diagram. We don't want have tests for expect "NullPointerException" (this situations should be fixed instead) :-).
- Status changed from In Progress to Needs feedback
- Assignee changed from Artem Kolychev to Vít Švanda
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Artem Kolychev
- % Done changed from 0 to 100
It looks nice. I merged it to the develop. Thanks for that.
- Status changed from Resolved to Closed
Also available in: Atom
PDF
