Feature #1438
closed
Validators for EAV attributes
Added by Ondřej Kopr over 5 years ago.
Updated about 5 years ago.
Description
For all eavs attributes will be implemented new feature validators.
Now will works these validation:
- required,
- regex,
- min,
- max,
- unique.
For validators will works prefly validation.
Validation will be implemented for IdmFormAttribute and overridden attribute in role.
Validators will not works for multivalued attributes.
- Assignee changed from Ondřej Kopr to Radek Tomiška
Please do it. Probably immediately.
- Related to Task #1408: Use regular expression as validator in EAV added
- % Done changed from 0 to 30
Basic BE validation are implemented. Validation error sent from BE is rendered as standard FE field validation. Remains implementing all types of validations (required implemented now).
- % Done changed from 30 to 50
Implemented all validation types on BE - min, max, regex, unique.
I'll continue with:
- showing better error message on FE for regular expressions
- prevent to lost filled values, when some validation fails (after request to BE)
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 50 to 90
I did review and everything looks correctly now (I completed copy of validation definitions to role attributes and I created tests for it).
I discovered only one potencial problem: In the case, when user creates two concept-role for same role where unique validation is enabled. In this case, user can create concepts with same value (not unique). Be default it is correct, because unique check should be executed against in the identityRole values. As future improvement could be implemented validation on unique EAV values whitin specific role-request.
Thanks for that.
Changes and tests: https://github.com/bcvsolutions/CzechIdMng/commit/f5551d9a645ef794d3c3371a4fe5e490d5c1352d
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
- Status changed from Resolved to Closed
- Related to Feature #1874: Support validations for multivalued eav attributes added
- Related to Defect #2035: Form attribute type double can be only integer/long added
- Related to Task #1195: Form values - add filters by value added
Also available in: Atom
PDF
