Project

General

Profile

Task #1195

Form values - add filters by value

Added by Radek Tomiška about 3 years ago. Updated 29 days ago.

Status:
Closed
Priority:
Normal
Category:
Eav
Target version:
Start date:
07/26/2018
Due date:
% Done:

100%

Estimated time:
Milestones:

Description

Add filters for form values tab on form definition and attribute detail. Filters for all persistent types could be supported. Create design at first.


Related issues

Related to CzechIdM - Task #1168: Form definition attributes values in form definition detailClosed07/04/2018

Related to CzechIdM - Feature #1438: Validators for EAV attributesClosed01/09/2019

History

#1 Updated by Radek Tomiška about 3 years ago

  • Related to Task #1168: Form definition attributes values in form definition detail added

#2 Updated by Radek Tomiška about 3 years ago

  • Related to Task #1052: delete non empty EAV (even with values) added

#3 Updated by Radek Tomiška about 3 years ago

  • Related to deleted (Task #1052: delete non empty EAV (even with values))

#4 Updated by Radek Tomiška about 3 years ago

  • Description updated (diff)

#5 Updated by Roman Kučera about 3 years ago

  • Status changed from New to In Progress

My solution how to implement this functionality, if I am missing something, please let me know.
FE:
Currently you can filter by persistence type. So when user choose one type I will dynamically show additional field for attribute value based on that type(date_value, double_value, ...). We have wide range of persistence types and I think using one text input is not user friendly.
After that I will send persistence type(we are already sending this) and value to BE.
BE:
In IdmFormValueFilter I'll add attributes for each persistence type
In method IdmFormValueController:toFilter I'll set the value to filter from parameters which I got.

#6 Updated by Roman Kučera about 3 years ago

  • % Done changed from 0 to 80

Filter for form values is implemented.
Branch https://github.com/bcvsolutions/CzechIdMng/tree/rkucera/1195-form-value-filter

Filter is in form values tab on form definition and attribute detail. In attribute detail it will be nice to preset the type and make it read only. I had some problems with setting the value and with the behavior when user use the button for filter reset and I don't want to spend to much time on it, because don't know if this will be necessary to implement, so I just leaving this commend here for possible discussion.

#7 Updated by Radek Tomiška 3 months ago

  • Status changed from In Progress to New
  • Assignee changed from Roman Kučera to Radek Tomiška
  • Target version set to 11.2.0
  • % Done changed from 80 to 0

#9 Updated by Radek Tomiška 2 months ago

  • Status changed from New to In Progress

#10 Updated by Radek Tomiška 2 months ago

#11 Updated by Radek Tomiška 2 months ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondrej Husník
  • % Done changed from 0 to 90

Feature is implemented, commit:
https://github.com/bcvsolutions/CzechIdMng/commit/5e149a938378c25a66f33728f9a1a55d5d0aac2b

Could you provide me a feedback, please?

#12 Updated by Ondrej Husník about 1 month ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Ondrej Husník to Radek Tomiška

I reviewed this feature. It works fine.
I noticed one thing.
The FE validation of int and long values uses the same range of values which corresponds to long. It's not true for int values. This validation should be separated. See FormValueTable.js.179 But it's not critical here.
The double value validation also uses incorrect range see the line 184. This can be more limiting.

#13 Updated by Radek Tomiška about 1 month ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondrej Husník

I improved validation for integers, commit:
https://github.com/bcvsolutions/CzechIdMng/commit/0ffafdf57456f606cc4b7e99fc072c1dddd010d3

Colud you provide me a feedback again please?

Note: Validation for double is the same is for input and is related to database data type.

#14 Updated by Ondrej Husník about 1 month ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondrej Husník to Radek Tomiška
  • % Done changed from 90 to 100

Nice, it looks better.

#15 Updated by Radek Tomiška 29 days ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF

Go to top