Task #141
closed
Task #134: Role detail on single detail content with tabs
Change userID to entityID and refactor activeItem
Added by Ondřej Kopr over 8 years ago.
Updated about 8 years ago.
Description
Child task #134
- remove please poarameter userID from TabPanel component and replace it to entityID on user detail (and profile etc.) - entityID will be used instead userID parameter.
- props activeItem (selectedSidebarItem) in TabPanel comonent is hard coded now to work with second navigation level only - could be refactored and can be controlled by parentId and selectedNavigationItems parameters.
This task will be solved until VS finish modularity.
- Status changed from New to In Progress
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 80
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
I made code review and test, i found some bugs:
- userID was forgotten in two modules (app, example) - i had to repair this immediately, because application doesn't start.
- ACTIVE_ITEM in TabPanel is hard coded to 1. Active item has to work in custom level (parentId has to be found in selectedNavigationItems - selected navigation on next position in selectedNavigationItems has to be used as tab panel active item).
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 80 to 90
- const ACTIVE_ITEM was removed and now is used parentId.
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Also available in: Atom
PDF
