Project

General

Profile

Actions
Copy link

Task #141

closed

Task #134: Role detail on single detail content with tabs

Change userID to entityID and refactor activeItem

Added by Ondřej Kopr over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Frontend
Target version:
Beryl
Start date:
09/20/2016
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Child task #134

  • remove please poarameter userID from TabPanel component and replace it to entityID on user detail (and profile etc.) - entityID will be used instead userID parameter.
  • props activeItem (selectedSidebarItem) in TabPanel comonent is hard coded now to work with second navigation level only - could be refactored and can be controlled by parentId and selectedNavigationItems parameters.

This task will be solved until VS finish modularity.

Actions
Copy link
 #1

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to In Progress
Actions
Copy link
 #2

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 80
FE:
  • 'userID' was refactor to 'entityId' routes and module descriptor was also changed, tests on FE
  • selectedSidebarItem and activeNavigationItem was deleted, now used only selectedNavigationItems and parentId

most changes were done in TabPanel.
One commit with #141 prefix - https://github.com/bcvsolutions/CzechIdMng/commit/7e45b0d23fbc8343235b3831382f971276b7b639

Please do code review and report me problems.

Actions
Copy link
 #3

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I made code review and test, i found some bugs:
  • userID was forgotten in two modules (app, example) - i had to repair this immediately, because application doesn't start.
  • ACTIVE_ITEM in TabPanel is hard coded to 1. Active item has to work in custom level (parentId has to be found in selectedNavigationItems - selected navigation on next position in selectedNavigationItems has to be used as tab panel active item).
Actions
Copy link
 #4

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 80 to 90
  • const ACTIVE_ITEM was removed and now is used parentId.
Actions
Copy link
 #5

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 90 to 100

Awesome!

Actions
Copy link

Also available in: Atom PDF