Task #1170
closed
Added by Radek Tomiška almost 6 years ago.
Updated almost 6 years ago.
Description
Role guarantee can be configured as identity select box. Add new tab for role guarantees to role detail, where guarantee can be configured by role select box:
- add new attribute to RoleGuarantee entity - targetRole (or create new entity)
- add new tab to role detail with role guarantee table
- Status changed from New to In Progress
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- % Done changed from 0 to 90
- Status changed from Needs feedback to In Progress
- Assignee changed from Vít Švanda to Radek Tomiška
I did test and review. Code looks nice and everything works fine.
One potencial problem can be in the method loads all guarantees by role. This method is calls int the approving WF and for 6000 identities create of the process takes about 10 minuts (but everything works).
I suggest use the limit to first 100 guarantees (from that WF process).
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Vít Švanda
- Status changed from Needs feedback to Closed
- Assignee changed from Vít Švanda to Radek Tomiška
- % Done changed from 90 to 100
That is much more better. For same example create of the task takes only 5s.
Thanks for that.
Also available in: Atom
PDF
