https://redmine.czechidm.com/https://redmine.czechidm.com/themes/purplemine2/favicon/favicon.ico?16339658642018-07-11T12:23:35ZIdStory Identity ManagerIdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=56762018-07-11T12:23:35ZVít Švanda
<ul><li><strong>Status</strong> changed from <i>New</i> to <i>In Progress</i></li></ul> IdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=56772018-07-11T12:25:55ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul></ul><p>I implemented new tab on role detail with role guarantees by role. Guarantees by identity is preserved as it is. I added new guarantees into filters for finding guarantees into WF and on identity detail - authorized roles.</p>
<p>Doc:<br /><a class="external" href="https://wiki.czechidm.com/devel/documentation/architecture/dev/events#entities_with_event_support">https://wiki.czechidm.com/devel/documentation/architecture/dev/events#entities_with_event_support</a></p>
<p>Commit:<br /><a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/00fd71b3e9a4daf5601f346cf0d74f9005e17746">https://github.com/bcvsolutions/CzechIdMng/commit/00fd71b3e9a4daf5601f346cf0d74f9005e17746</a></p>
<p>Could you please do a review?</p> IdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=56782018-07-11T12:26:20ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Vít Švanda</i></li><li><strong>% Done</strong> changed from <i>0</i> to <i>90</i></li></ul> IdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=56842018-07-11T14:35:57ZVít Švanda
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>In Progress</i></li><li><strong>Assignee</strong> changed from <i>Vít Švanda</i> to <i>Radek Tomiška</i></li></ul><p>I did test and review. Code looks nice and everything works fine.</p>
<p>One potencial problem can be in the method loads all guarantees by role. This method is calls int the approving WF and for 6000 identities create of the process takes about 10 minuts (but everything works).</p>
<p>I suggest use the limit to first 100 guarantees (from that WF process).</p> IdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=56882018-07-12T11:23:05ZRadek Tomiškaradek.tomiska@bcvsolutions.eu
<ul><li><strong>Status</strong> changed from <i>In Progress</i> to <i>Needs feedback</i></li><li><strong>Assignee</strong> changed from <i>Radek Tomiška</i> to <i>Vít Švanda</i></li></ul><p>Thx for feedback, I agree. I've added pageable parameter to find guarantees method and use her in workflow with limit 100.</p>
<p>Commit: <a class="external" href="https://github.com/bcvsolutions/CzechIdMng/commit/6fe4d158bc8d4d1852c8fd0e12da0d74bf5e9dfb">https://github.com/bcvsolutions/CzechIdMng/commit/6fe4d158bc8d4d1852c8fd0e12da0d74bf5e9dfb</a></p>
<p>Could you do a review again, pls?</p> IdStory Identity Manager - Task #1170: Role - guarantee by rolehttps://redmine.czechidm.com/issues/1170?journal_id=57052018-07-16T10:50:51ZVít Švanda
<ul><li><strong>Status</strong> changed from <i>Needs feedback</i> to <i>Closed</i></li><li><strong>Assignee</strong> changed from <i>Vít Švanda</i> to <i>Radek Tomiška</i></li><li><strong>% Done</strong> changed from <i>90</i> to <i>100</i></li></ul><p>That is much more better. For same example create of the task takes only 5s.</p>
<p>Thanks for that.</p>