Task #1168
closed
Form definition attributes values in form definition detail
Added by Roman Kučera over 6 years ago. Updated over 6 years ago.
100%
Description
New tab in form definition detail, which will display form values for its attributes.
Make this agenda read only in first place.
Make filter for searching in displayed values.
Then the functionality can be further extended - for example make bulk operation for it. Display entity info on each row, etc.
Related issues
Updated by Roman Kučera over 6 years ago
- Subject changed from Form definition attributes in form definition detail, to Form definition attributes values in form definition detail
Updated by Roman Kučera over 6 years ago
Green line implemented.
I created new service and controller on BE, then created new tab on FE in form definition detail, where you can see attributes values in table.
Need to implement filter based on owner, attr. name, etc.
I have owner uuid need to somehow get username to display it in table with the nice preview and redirect to owner identity.
Need to make code cleanup and consult, if the implementation is in correct way.
Updated by Roman Kučera over 6 years ago
Filter by name or code is working.
Columns sorting is broken.
Value is displaying from attribute "value", it will be probably better to display it from the typeValue - doubleValue, etc...
Attribute values is now showing only in form definition for IdmIdentity, because service class is using IdmIdentityFormValueReposity, need to figure it out how to make it (Decide which repository to use in service class? Service class for each type of form values? Some other solutions?)
Updated by Roman Kučera over 6 years ago
Added filter by persistent type.
Added new side menu for attribute detail (Form definitions -> select one definition -> Form Attributes -> select one -> here is new tab with and page with attribute values)
In table user is displayed via EntityInfo component.
Sorting for columns is forbidden now.
Updated by Roman Kučera over 6 years ago
Implementation in rkucera/1168-attribute-value-tab
Updated by Roman Kučera over 6 years ago
- Assignee changed from Roman Kučera to Radek Tomiška
- % Done changed from 0 to 60
Main issue is that its still work only for form definitions which is type of IdmIdentityFormValue. I made some attempts to fix this but its was unsuccessful. When I want to use AbstractFormValueRepository in IdmServiceConfiguration then the server wont start because spring can not create context for some methods in AbstractFormValueRepository. I tried this with removed MappedSuperclass annotation in that repository.
Just for testing purpose tried to commend these methods a make some other changes as added Entity annotation to AbstractFormValue, app then start but I was working with abstract repository and it find nothing.
Tried to google how work with multiple repositories which has some abstract repository but it doesn't help me to fix this.
Version which is in git is the one which only works for one type.
Updated by Radek Tomiška over 6 years ago
- Assignee changed from Radek Tomiška to Roman Kučera
- Target version set to Malachite (9.0.0)
- % Done changed from 60 to 90
Thx for this feature !I did test, review and refactored / fixed:
- form values for all owner types is supported now (i has to redesign / remove created backend services - form service is used now).
- created controller was redesigned:
-- uses form service
-- path was changed to 'form-values'
-- missing swagger annotation added
-- missing findQuick method added
- service and manager on FE:
-- renamed to FormValueService / FormValueManager (the same convention as other form services)
-- unused method getAttributeValues removed
- locales changed - moved under entity key (the same convention as other form entities / dtos)
- the new attribute detail fixed:
-- layout (+css)
-- getIsNew method - returned / rendered string '1' instead returning true / false.
- columns configuration for FE table added - columns with attribute name and code are hidden on attribute values tab
- sort support for FE table added (instead owner and value column)
- default search parameters added into FE service - table is sorted now by attribute name by default
- navigation and localization keys were changed (form-values everywhere)
Commit with redesign:
https://github.com/bcvsolutions/CzechIdMng/commit/6a4b07e55355a4cbc1145c86c17acd6f70d62f87
Remains:
- add test for IdmFormValueController (see AbstractReadWriteDtoControllerRestTest for inspiration) and FormService#findValues method (into DefaultFormServiceItegrationTest).
Then this task can be closed. Other improvements (like filter by value) will be implemented in another tickets.
Updated by Radek Tomiška over 6 years ago
- Related to Task #1195: Form values - add filters by value added
Updated by Radek Tomiška over 6 years ago
- Related to Task #1196: Form values - add bulk action for delete added
Updated by Roman Kučera over 6 years ago
- Assignee changed from Roman Kučera to Radek Tomiška
Thank you for review and for fixing the issue.
I implemented tests and make small fixes on FE which caused eslint errors.
branch rkucera/1168-attribute-values
Updated by Radek Tomiška over 6 years ago
- Status changed from In Progress to Closed
- Assignee changed from Radek Tomiška to Roman Kučera
- % Done changed from 90 to 100
I did review, it works and code looks nice, thx! I did just some minor corrections:
https://github.com/bcvsolutions/CzechIdMng/commit/4673b55830278c4290cfac43a75504fe07dfc32a
Merged into develop.