Project

General

Profile

Actions
Copy link

Task #98

closed

Component Basic.Table - property noData is not localized

Added by Radek Tomiška over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Low
Assignee:
Radek Tomiška
Category:
Frontend
Target version:
Amethyst
Start date:
08/18/2016
Due date:
% Done:

100%

Estimated time:
1.50 h
Owner:

Description

Default noData property value of Basic.Table should be in english. Component Advanced.Table could load and fill noData default property from locale (e.g. Basic.SelectBox.getPlaceholder(placeholder)).

Note: Basic components should not access to context directly (to get LocalizationService in this case). On the other hand advanced components have access to context naturally.

Actions
Copy link
 #1

Updated by Radek Tomiška over 7 years ago

  • Status changed from New to In Progress
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Actions
Copy link
 #2

Updated by Radek Tomiška over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90
  • Estimated time set to 1.50 h

I've added localization to advanced table and propagated it to basic table.

Retest and review my changes, please.

Actions
Copy link
 #3

Updated by Ondřej Kopr over 7 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

In Advance.Table found localization - method i18n, also found default value 'No record found' - OK
In Basic.Table found property noData - OK
Commit with tag #98 not found

Result - OK

Actions
Copy link
 #4

Updated by Ondřej Kopr over 7 years ago

My bad.
Commit with tag #98 found - OK

Actions
Copy link
 #5

Updated by Radek Tomiška over 7 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF