Task #894
closed
Show identities that has automatic role by attribute
Added by Ondřej Kopr almost 7 years ago. Updated almost 7 years ago.
100%
Description
Add new table to automatic role detail with all identities that has this automatic role.
Probably you will need add tabs for automatic role detail and also separate table with rules into new tab.
Files
| auto_roles.png (72.7 KB) auto_roles.png | Ondřej Kopr, 01/08/2018 11:10 AM | ||
| feed01.png (21.9 KB) feed01.png | Ondřej Kopr, 01/26/2018 10:00 AM |
Related issues
Updated by Marcel Poul almost 7 years ago
- Assignee changed from Ondřej Kopr to Petr Adamec
Updated by Petr Adamec almost 7 years ago
- Status changed from New to In Progress
Updated by Petr Adamec almost 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Petr Adamec to Ondřej Kopr
- % Done changed from 0 to 90
I had pushed solution of this task to branch adamecp/894-Show-identities-that-has-automatic-role-by-attribute. Please review.
Updated by Ondřej Kopr almost 7 years ago
- File feed01.png feed01.png added
- Status changed from Needs feedback to In Progress
- Assignee changed from Ondřej Kopr to Petr Adamec
- % Done changed from 90 to 80
I made review:
- filter IdentityAutomaticRoleFilter has unsatisfactory description: "Filter by identity state" + new line,
- title for tabs rules and users with roles doesn't works,
- for tab users with roles doesn't works selected items,
- localization for filter in users with roles missing,
- create detail for automatic role has probably two panels see picture:
- method select is useless in AutomaticRoleAttributeIdentities,
- please in AutomaticRoleAttributeIdentities and AutomaticRoleAttributeRoutes format render method, there is more tabs,
- in AutomaticRoleAttributeContent is defined entityId from this.props, but this props will be same in all case = undefined,
- in AutomaticRoleAttributeContent props showLoading is never used you can remove it,
- please discuss with Marcel new behavior, because when I had automatic role in concept state, is information about it show only in detail + button.
After you will solve this issues, please give me this ticket back.
Updated by Petr Adamec almost 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Petr Adamec to Ondřej Kopr
- % Done changed from 80 to 90
I have solved issues and push result to branch adamecp/894-Show-identities-that-has-automatic-role-by-attribute
The branch includes some changes mergered from branch develop
I have discussed with Mracel about new behavior. New behavior is not necessary for now.
Updated by Ondřej Kopr almost 7 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
I resolved some conflicts:
CONFLICT (content): Merge conflict in Realization/frontend/czechidm-core/src/locales/en.json CONFLICT (content): Merge conflict in Realization/frontend/czechidm-core/src/locales/cs.json CONFLICT (content): Merge conflict in Realization/frontend/czechidm-core/src/content/automaticrole/attribute/AutomaticRoleAttributeRuleContent.js CONFLICT (add/add): Merge conflict in Realization/frontend/czechidm-core/src/content/automaticrole/attribute/AutomaticRoleAttributeRoutes.js CONFLICT (add/add): Merge conflict in Realization/frontend/czechidm-core/src/content/automaticrole/attribute/AutomaticRoleAttributeIdentities.js CONFLICT (content): Merge conflict in Realization/frontend/czechidm-core/src/content/automaticrole/attribute/AutomaticRoleAttributeDetail.js CONFLICT (content): Merge conflict in Realization/frontend/czechidm-core/src/content/automaticrole/attribute/AutomaticRoleAttributeContent.js CONFLICT (add/add): Merge conflict in Realization/backend/core/core-impl/src/main/java/eu/bcvsolutions/idm/core/model/repository/filter/IdentityAutomaticRoleFilter.java
I made some mirror fixes: https://github.com/bcvsolutions/CzechIdMng/pull/19/commits/83a583c830fc45eedc67174d65bfbb75ca71257a
pull request: https://github.com/bcvsolutions/CzechIdMng/pull/19
Please Radek could you made final review? Thank you.
Updated by Radek Tomiška almost 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Petr Adamec
- Target version set to Hematite (8.0.0)
- % Done changed from 90 to 100
I did test, review and refactoring:
- filter is available for automatic roles by tree nodes
- layout and rotes for create new aut. role by attribute is fixed
- filter builder - removed redundant subquery
- FE formatting etc.
Feature is merged into develop.
Updated by Radek Tomiška almost 7 years ago
- Due date set to 02/07/2018
- Start date changed from 01/08/2018 to 02/07/2018
- Follows Task #950: Show identities that has automatic role by tree added
Updated by Radek Tomiška almost 7 years ago
- Target version changed from Hematite (8.0.0) to Garnet (7.8.0)