IdStory Identity Manager

modified script filter, service, controller
on frontend edited system mappings force search parameters

commits:
https://github.com/bcvsolutions/CzechIdMng/commit/5eb3f8bcf1e1d599c3ded82b385a97d32d2e1f6a
https://github.com/bcvsolutions/CzechIdMng/commit/8ff9b519800dafa6e6948c5acaa45d2ad6afaa28

pull request:
https://github.com/bcvsolutions/CzechIdMng/pull/11

I had to implement toFilter even you said that it is not necessary.
Please review my implementation and send feedback.

Update request for this task: After discussion instated of remove script categories "Transformation from" and "Transformation to" just will be added new property to script filter something like "categoryIn".

• I check code in FE SystemAttributeMappingDetail.js:
  

  const inCategory = [Enums.ScriptCategoryEnum.findKeyBySymbol(Enums.ScriptCategoryEnum.TRANSFORM_FROM), Enums.ScriptCategoryEnum.findKeyBySymbol(Enums.ScriptCategoryEnum.TRANSFORM_TO)];
  

  
  this will not works, you add category TRANSFORM_TO to TRANSFORM_FROM, evaluator check if category correspond with evaluator category or DEFAULT category. You must add this filter for TRANSFORM_FROM and TRANSFORM_TO, but array with categories must be like:
  

  const inCategoryTransformationTo = [Enums.ScriptCategoryEnum.findKeyBySymbol(Enums.ScriptCategoryEnum.TRANSFORM_TO), Enums.ScriptCategoryEnum.findKeyBySymbol(Enums.ScriptCategoryEnum.DEFAULT)];
  

  ,
• you add new props scriptCategories for advanced component ScriptArea, but you never use this props, you can delete this props, sorry I missed last your commit.

Thank you for add this new feature, please fix this small issue and then give me this ticket back, I check this new funkcionality.

so i resolved that issue from feedback, please try this new feature

https://github.com/bcvsolutions/CzechIdMng/commit/ace645870f564e7623677a6f02da50b8e77bc5ec

I made second feedback:

*- your solution doesn't works. Did you try your feature after you developing it? I got this error message:
-

eu.bcvsolutions.idm.core.api.exception.ResultCodeException: The filter is wrong!
...
Caused by: java.lang.IllegalArgumentException: Can not deserialize instance of java.util.ArrayList out of VALUE_STRING token
 at [Source: N/A; line: -1, column: -1] (through reference chain: eu.bcvsolutions.idm.core.api.dto.filter.IdmScriptFilter["inCategory"])
    at com.fasterxml.jackson.databind.ObjectMapper._convert(ObjectMapper.java:3459)
    at com.fasterxml.jackson.databind.ObjectMapper.convertValue(ObjectMapper.java:3378)
    at eu.bcvsolutions.idm.core.api.utils.FilterConverter.toFilter(FilterConverter.java:56)
    ... 123 common frames omitted
Caused by: com.fasterxml.jackson.databind.JsonMappingException: Can not deserialize instance of java.util.ArrayList out of VALUE_STRING token
 at [Source: N/A; line: -1, column: -1] (through reference chain: eu.bcvsolutions.idm.core.api.dto.filter.IdmScriptFilter["inCategory"])
    at com.fasterxml.jackson.databind.JsonMappingException.from(JsonMappingException.java:148)

I made my final feedback, sorry for before disorientation, probably bug with switching branches I'm so sorry :( :)

I check FE component for pick scripts and everything works awesome, also BE part is OK. for me is this new feature OK and awesome!

Please Radek could you make a final review and merge this branch into develop

branch: https://github.com/bcvsolutions/CzechIdMng/tree/pstloukal/883-edit-script-categories
pull request: https://github.com/bcvsolutions/CzechIdMng/pull/11

Thanks

Thx for this new feature, it works and code looks nice. I added some improvments:
- prevent to retur 'null' lists - see IdmScriptFilter
- using parameter converter for multiple filter parameters - see IdmScriptController

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/f748929e8eddb29f546b0d0b006b171e116f1432

Merged into develop.