IdStory Identity Manager

Please merge CSV connector

http://nexus.bcvsolutions.eu/#browse/browse/components:maven-public-releases:912d0fe7b8192392b401a3aaa448310c

We checked standard behavior of your connector, there is some mirror bugs:

• if connector doesn't support provisioning, please throw exception. Information in documentation isn't sufficient,
• made synchronization from file that must be ordered by some column is really uncomfortable (please implement synchronization by token and some filter, or allow only reconciliation - discuss this with some good implement guy),
• i just little bit read some code form your connector and I found lines where you throw IllegalArgumentException, this isn't nice, try throw some better exception eq. ConnectorException.

If you want help with implementetaion feel free to discuss with me.

EDIT: please create some future repository in our ghithub for final version of your connector

I solved some problems in the connector:

• as mentioned, the connector doesn't support provisioning, so an exception is thrown if someone tries to proceed it
• synchronization is now disabled too. Is used similarly as in provisioning - so just reconciliation is working.
• all exceptions were replaced by ConnectorException - except ConfigurationExceptions

Can you please do [[https://git.bcvsolutions.eu/modules/csv-connector|code]] review for me.

Thanks

I made first review:

• for your class missing autor, be proud for your code (this connector will be part of public github), also please unite your autor name,
• your connector has silent exception. It is hardly needed throw this exception back to caller (maybe some wrap). Example:
  

  } catch (IOException e) {
         e.printStackTrace();
  }
  

• check unused imports,
• your log errors are composed with string + string. LOG supports {} for example:
  

  // old
  LOG.info("ATTRIBUTE "+attribute.getName()+" WITH value "+attribute.getValue()+ " compare to ATTRIBUTE "+attributeValue);
  
  // better
  LOG.info("ATTRIBUTE [{}] WITH value [{}] compare to ATTRIBUTE [{}]", attribute.getName(), attribute.getValue(), attributeValue);
  

• format your code,
• im not able read some attributes names for example: ret and bh, try apply clean code, another example:
  

  // this is realy ugly
  AttributeBuilder abID = new AttributeBuilder();
  AttributeBuilder abF = new AttributeBuilder();
  AttributeBuilder abL = new AttributeBuilder();
  AttributeBuilder abG = new AttributeBuilder();
  AttributeBuilder abGg = new AttributeBuilder();
  

• change IllegalArgumentException to connector exception,
• please add some javadoc, even for private methods, you behavior with iterator is little bit hard to read (or use forEach, stream?),
• you didn't close csv reader! while is throw some error reader is still open, please use final statement and close it in final,
• tests for connector didn't pass,
• bad package, for every new connector must be package eu.bcvsolutions.idm.connectors.

Please fix this minor issues, then I will be continue with review.

Packages do not work properly. Cannot find messages for the connector. Can you please check it Ondro?

I fixed package name and version, then I try build and run your connector, this change works correctly. Please continue with feedback.

• clean your project, remove target folder,
• update correctly your property eq: ic.localconnector.packages=eu.bcvsolutions.idm.connectors.csv.

• Added author to each class and unified name - should be everywhere
• Get rid of silent exception like this:
  

  } catch (IOException e) {
         throw new ConnectorException(e);
  }
  

• checked unused imports - default funcion of IDEA - hopefuly non left
• changed log messages as recommended
• formatted code,
• changed ugly attributes names - every attribute name now seems ok
• couldn't find any other IllegalArgumentException left - tried to find in the project and by looking
• added javadoc
• closed all readers - please check if this works
• tests now work - could not resolve path after a change of directory. Also ignored tests for unsupported methods (exceptions are thrown)
• package is changed to eu.bcvsolutions.idm.connectors

Nice, now your connector works. You can release first version of your connector and publish your connector to public nexus and github.

CSV connector was released, there is public git repository: https://github.com/bcvsolutions/csv-connector
nexus public repository: http://nexus.bcvsolutions.eu/#browse/browse/components:maven-public-releases:c60bc6b9612f47d3eefc416e9cf4fd57

maven dependency:

<dependency>
    <groupId>eu.bcvsolutions.idm.connectors.csv</groupId>
    <artifactId>csv-connector</artifactId>
    <version>1.0.0</version>
</dependency>

To product was create new pull request: https://github.com/bcvsolutions/CzechIdMng/pull/38

Now can be the csv connector use by another project. Good job.