Project

General

Profile

Actions
Copy link

Task #86

closed

Send notification from FE

Added by Radek Tomiška almost 8 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Messaging
Target version:
Amethyst
Start date:
08/09/2016
Due date:
% Done:

100%

Estimated time:
4.00 h
Owner:

Description

Implement form for sending notification from FE - entry point will bee agenda of notification with green add button (like adding new identity).
Form could be reused from NotificationDetail component (make it editable).
Rest post method on notification resource endpoint should be used (prepared appropriate handler - IdmNotificationLogEventHandler.handleAfterCreate) - nofification will be saved and sent.

Related issues

Related to IdStory Identity Manager - Task #65: MessagingClosedRadek Tomiška07/01/2016

Actions
Related to IdStory Identity Manager - Defect #105: Sender is associate in recipientsClosedRadek Tomiška08/18/2016

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška almost 8 years ago

Actions
Copy link
 #2

Updated by Radek Tomiška almost 8 years ago

  • Assignee changed from Radek Tomiška to Ondřej Kopr
Actions
Copy link
 #3

Updated by Ondřej Kopr over 7 years ago

  • Status changed from New to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 0 to 90
Actions
Copy link
 #4

Updated by Radek Tomiška over 7 years ago

  • Related to Defect #105: Sender is associate in recipients added
Actions
Copy link
 #5

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Ondřej Kopr
I've done test and code review. Sending notifications works nice, i found some issues:
  • method showDetail and closeDetail is useless now - please remove them correctly
  • when notification is sent, then showLoading on detail should be shown
  • after successfully sending, better message could be shown (sending was ok, not saving .))
  • button add + save could have better localization (we are sending notification)
  • after notification is sent, then _this.refs.table is undefined error occurs
Actions
Copy link
 #6

Updated by Ondřej Kopr over 7 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Radek Tomiška
Fix errors:
  • method closeDetail it was removed from NotificationDetail, but method showDetail from NotificationTable is nessesary to route detail and create new notification.
  • localization message it was fix to send and sending.
  • problem with undefined table reference is correct in task #105.
  • Buttons localization correct
  • showLoading add state after save.
Actions
Copy link
 #7

Updated by Ondřej Kopr over 7 years ago

  • % Done changed from 90 to 100
Actions
Copy link
 #8

Updated by Radek Tomiška over 7 years ago

  • Status changed from Needs feedback to Closed
  • Assignee changed from Radek Tomiška to Ondřej Kopr

It works and code looks nice.

Actions
Copy link

Also available in: Atom PDF