Project

General

Profile

Actions

Defect #105

closed

Sender is associate in recipients

Added by Ondřej Kopr over 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Notification
Target version:
Start date:
08/18/2016
Due date:
% Done:

100%

Estimated time:
4.00 h
Affected versions:
Owner:

Description

When create new notification is sender assigned to recipient.

@OneToMany(mappedBy = "notification", cascade = CascadeType.ALL)

Related issues

Related to IdStory Identity Manager - Task #86: Send notification from FEClosedOndřej Kopr08/09/2016

Actions
Actions #1

Updated by Radek Tomiška over 8 years ago

  • Status changed from New to In Progress
Actions #2

Updated by Radek Tomiška over 8 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

I've repaired showing sender in recipients. Sender is now realizated as reference to identity.

I've repaired more things:
  • duplicit Emails localization was removed,
  • using unexisted refs (this.refs.form) when notification detail closes was removed
  • duplicit footer on email detail was removed.

other notes from code review will be included in #86.

Retest and review my changes please.

Actions #3

Updated by Radek Tomiška over 8 years ago

  • Related to Task #86: Send notification from FE added
Actions #4

Updated by Ondřej Kopr over 8 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

Feedback:

After save (send) notification it was error - call getWrappedInstance on undefined.
Solutions:
Remove this unless check to error and reload instance of table in NotificationDetail. (there isnt table refrence).

if (!error) {
   this.refs.table.getWrappedInstance().reload();
}

Status: OK.

Actions #5

Updated by Radek Tomiška over 8 years ago

  • Status changed from Resolved to Closed

I didn't fix error with call getWrappedInstance on undefined - i've included it in #86 review, where error was created .) Super, when is fixed right now .)

Actions #6

Updated by Radek Tomiška over 5 years ago

  • Tracker changed from Task to Defect
  • Category changed from 20 to Notification
Actions

Also available in: Atom PDF