Task #856
closed
Allow admin to configure OperationOptions for each operation type
Added by Peter Štrunc over 6 years ago. Updated about 4 years ago.
100%
Description
ConnId framework allows client to pass some additional properties to each operation in the form of OperationOptions. It would be nice if admin had some way to configure these operation options for each type of operation (create, update, search...). This is necessary for example for ConnIdAdBundle.
Related issues
Updated by Vít Švanda over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Vít Švanda to Peter Štrunc
Which exactly OperationOptions do you need?
Operations: OperationOptions.OP_PAGE_SIZE, OperationOptions.OP_PAGED_RESULTS_OFFSET, OperationOptions.OP_PAGED_RESULTS_COOKIE, OperationOptions.OP_PAGED_RESULTS_OFFSET are already implemented in the search (IC module). But are not fully tested (none from tested connectors/ldaps returned cookies ... for my tests in past).
Updated by Vít Švanda over 6 years ago
- Status changed from Needs feedback to New
Updated by Peter Štrunc over 6 years ago
- Assignee changed from Peter Štrunc to Vít Švanda
- Pagination - Each search operation should use pagination by default. Configuration of page size and other related stuff should be available in system configuration (hidden under advanced) along with the possibility to disable paging for given system.
- Attributes to get - Admin should be able to specify which attributes will be returned from system. It would be nice to somehow pair it with schema definition.
Updated by Alena Peterová almost 6 years ago
Peter Šourek wrote:
- Attributes to get - Admin should be able to specify which attributes will be returned from system. It would be nice to somehow pair it with schema definition.
This is especially needed by LDAP and AD connector for managing groups by the non-authoritative Merge strategy.
These connectors manage group membership by special attributes "ldapGroups" and "posixGroups". The connectors use these attributes during create/update, but don't return them by default. So Merge works the same as Authoritative Merge.
Sometimes we can use "memberOf" for managing groups, which is returned by default, but it doesn't work in all environments.
Therefore, please allow to specify OperationOptions.ATTRIBUTES_TO_GET.
Updated by Vít Švanda almost 6 years ago
- Priority changed from Normal to High
- Target version set to Malachite (9.0.0)
Updated by Vít Švanda over 5 years ago
- Target version deleted (
Malachite (9.0.0))
Updated by Peter Štrunc about 4 years ago
- Assignee changed from Vít Švanda to Peter Štrunc
Updated by Peter Štrunc about 4 years ago
- Status changed from In Progress to Needs feedback
- % Done changed from 0 to 70
Implemented functionality is in branch pstrunc/856-operation-options
Documentation can be found here: https://wiki.czechidm.com/devel/documentation/systems/dev/system-mapping#additional_connector_configuration
I also created merge request here: https://github.com/bcvsolutions/CzechIdMng/pull/102
@svandav would you lease review this ticket? Thank you :)
Updated by Vít Švanda about 4 years ago
- Assignee changed from Peter Štrunc to Vít Švanda
Updated by Vít Švanda about 4 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Peter Štrunc
- % Done changed from 70 to 100
I did review and test. It's great and correctly works feature. Thanks for it.
Nice usage of mockito tests. I'm not a fan of this tests, but in this case are usefull I think. I have only one comment for your tests. We don't use @FixMethodOrder anymore. I used this in past, but this wasn't good pattern.
I found some minor issues, generally with unresolved warnings. I fixed all these issues now, but please be more care about this for next time.
- You haven't not configured linter on FE. You left a lot of warnings in FE code!
- Use MessageFormat for join a strings instead '+' on BE.
- Fill in yourself as an author ;).
- I like your link for "Manage attributes". This link didn't work ... route was renamed in develop.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/d6045e07a0cc8a3981bafe7c0d4e63ff8090dbd1
Updated by Vít Švanda about 4 years ago
- Related to Task #2174: Export additional connector options as part of the system export added
Updated by Radek Tomiška about 4 years ago
- Status changed from Resolved to Closed