IdStory Identity Manager

Please for next time change state of task to needs feedback :)

edit: and give me some information about commits/branch where I find this feature + some minimalist information about your new behavior is also good idea.

I made first feedback:

• in FE component SystemRoles is defined method showDetail, this method is necessary remove it,
• into system role table please add detail button: ,
• Advanced.Column hasn't props access please remove it,
• eslint annotation for multi component isn't required more you can remove it,
• set sort 'dsc' for search parameter isn't working, use desc or asc,
• in localization you use 'entity.IdentityRole' but this is role try 'entity.Role',
• in select method you defined role and _showLoading props but these props is never used you can remove it,
• you are add some localization items to core entity IdentityRole, please remove it, use 'entity.Role',
• content key is 'acc:content.systemRoles' but probably better is 'acc:content.system.roles', for example like in system connector,
• please add filter to this table for role.

After you complete this feedback return the task to me, i will continue with review.

I found two yours branches, that correspond with this ticket, please for next time give me information in what branch is your new feature:
https://github.com/bcvsolutions/CzechIdMng/tree/786-assigned-roles-tab-in-system-detail
https://github.com/bcvsolutions/CzechIdMng/tree/phanak/786-assigned-roles-tab-in-system-detail

Into your original branch I already merged develop I must do this again.

• unused import UUID, for next time check eslint,
• your new filter doesn't work:
  

  Uncaught TypeError: Cannot read property 'getDefaultSearchParameters' of undefined
      at FilterSelectBox._createSearchParameters (app.js:45021)
      at FilterSelectBox.getOptions (app.js:45047)
      at FilterSelectBox.onOpen (app.js:45571)
      at Object.componentWillUpdate (app.js:24415)
  

  
  for next time try it, you forgot add manager into your select box,
• your new filter filtering by roleSystem, but SysRoleSystemFilter doesn't has this property,
• you still don't remove props role and _showLoading,
• localization items aren't still removed,

I already removed old branch. Current branch: https://github.com/bcvsolutions/CzechIdMng/tree/phanak/786-assigned-roles-tab-in-system-detail
My commit: https://github.com/bcvsolutions/CzechIdMng/commit/05683632c2a7b802031c18da2c3f89962aa26821
pull request: https://github.com/bcvsolutions/CzechIdMng/pull/12

Please Radek could you made a last review? Thank you.

I did test and review, new tab with roles works basically, we need to add some improvement:
- table is copied from original tab - crate pls new component with table and use her on both places (see IdentityTable and their props - forceSearchParameters, columns ...)
- add button is missing
- detail button leads to role detail - RoleSystem detail should be shown
- remove defining sort in forceSearchParameters - this means table cannot be sorted by user
- use info cards in table for role and system columns. Hide one of this column when role detail tab or system detail tab is used (see prop columns usage)

My adjustments:
- created new component - RoleSystemTable
- this component is used in RoleSystems and SystemRoles tabs
- add button added to RoleSystems tab (I was not sure how to implement it on SystemRoles)
- detail button is repaired and points to RoleSystem detail from both places
- table can be sorted by user
- added select boxes
- added info cards

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/7027ca44e67f4f1abd46fdf0db85df811e2ea167