Task #723
closed
Create IdentitySelect and RoleSelect component
Added by Radek Tomiška over 6 years ago.
Updated over 6 years ago.
Description
Wrap selects for identity and role into new components (encapsulate manager setting, searchInFields etc.) and register them by component descriptor.
- Precedes Defect #713: To many identities in selectbox added
- Status changed from New to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- Target version set to Forsterite (7.6.0)
- % Done changed from 0 to 90
I created new component EntitySelectBox, this component is now used only on RoleDetail guarantees (after success feedback, is possible add this component to another places)
Component EntitySelectBox uses information from component-descriptor and is possible, add searchInFields, manager, own component (default is SelectBox) and etc. see readme.
Please Radek could you make a review? Thank you :)
commit: https://github.com/bcvsolutions/CzechIdMng/commit/5485777a9424f0c1433c04a0d9b260842aa8cbde
- Assignee changed from Ondřej Kopr to Radek Tomiška
- Status changed from In Progress to Needs feedback
I forgot add needs feedback state, sorry :(
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 80
I did test and review, it works and component registration is awesome!
I did some refactoring, some things remain:
- validation (required etc) doesn't work
- onChange parameter doesn't work (check all others AbstractFormComponent method and delegate them to inner select box component - the same as setValue, getValue)
- add localization to entity properties, which are shown in default help block
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 80 to 90
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Awesome, works and looks nice.
Also available in: Atom
PDF
