Task #716
closed
Send notification with information about password change
Added by Ondřej Kopr over 7 years ago. Updated almost 7 years ago.
100%
Description
After success password change, send notification to user that own account. Send one notification for all changed accounts or send notification for every account.
Files
| email_example.png (21 KB) email_example.png | Ondřej Kopr, 01/11/2018 11:30 AM |
Related issues
Updated by Ondřej Kopr about 7 years ago
- Target version deleted (
Emerald (7.5.0))
Updated by Ondřej Kopr about 7 years ago
- Assignee changed from Ondřej Kopr to Patrik Stloukal
Updated by Patrik Stloukal about 7 years ago
- Status changed from New to In Progress
created notification template, edited CoreModuleDescriptor,
Updated by Patrik Stloukal about 7 years ago
- % Done changed from 0 to 80
edited notification template, created IdentityPasswordChangeNotificationProcessor, tested on idm
commits:
https://github.com/bcvsolutions/CzechIdMng/commit/2ad3d1dee730dc7210b0dba718eb1bb1f5aa693c
https://github.com/bcvsolutions/CzechIdMng/commit/440871d5c9f9efd36784ce33666f60e7de7eb8d5
Updated by Patrik Stloukal almost 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Patrik Stloukal to Ondřej Kopr
- % Done changed from 80 to 90
i used .stream instead of for each,
please do review my implementation
commit: https://github.com/bcvsolutions/CzechIdMng/commit/2dd5fb191660f0b735deba7ec9c2203db844c7f8
https://github.com/bcvsolutions/CzechIdMng/commit/dc0cc0ebae4502248bafa2a606a010d196d9550f
Updated by Ondřej Kopr almost 7 years ago
- File email_example.png email_example.png added
- Status changed from Needs feedback to In Progress
- Assignee changed from Ondřej Kopr to Patrik Stloukal
- % Done changed from 90 to 80
I made first feedback, I found only small issues:
- please when you create some class try format (eclipse: shift+crt+f),
- try also format method sendNotification in IdentityPasswordChangeNotificationProcessor
- filtering by res.getCode().equals(this.code) isn't good idea you cant use getStatusEnum() and compare enum,
- use string in code isn't also good idea, at least add constant,
- 'CzechIdm' isn't correct look at www.czechidm.com -> 'CzechIdM',
- i'm not good UX or design expert, please consult your new template with message with someone who is more competent (for example Marcel):
otherwise you logic works well, thank you for this feature, please fix this small issues and then give me the ticket back for next review, thank you.
Updated by Patrik Stloukal almost 7 years ago
- Assignee changed from Patrik Stloukal to Ondřej Kopr
- % Done changed from 80 to 90
I consulted design of template with Marcel and now it should be ok.
Other issues are now fixed.
Please could you review my code?
commits: https://github.com/bcvsolutions/CzechIdMng/commit/b6ab2f18d96f5c8a33dc881ae28bf66f5e4aabe9
https://github.com/bcvsolutions/CzechIdMng/commit/2108dd6dc9d2d496a43608391deb4a608a5c46cb
Updated by Ondřej Kopr almost 7 years ago
- Status changed from In Progress to Needs feedback
Updated by Ondřej Kopr almost 7 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
- from last feedback: use string in code isn't also good idea, at least add constant,
- better format message builder:
commit: https://github.com/bcvsolutions/CzechIdMng/commit/54c1efa0dcfa16a8081b95a8fe96999ee2152f13
Thank you Marcel for check template and you Patrik for this new feature.
Radek please check this feature and merge it in develop? Thank you.
Pull request: https://github.com/bcvsolutions/CzechIdMng/pull/18
Diff: https://github.com/bcvsolutions/CzechIdMng/pull/18/files
Updated by Radek Tomiška almost 7 years ago
- Target version deleted (
Garnet (7.7.0))
Updated by Radek Tomiška almost 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Patrik Stloukal
- Target version set to Garnet (7.8.0)
- % Done changed from 90 to 100
Thx for this new feature, it works. I did refactoring:
- reused notification template from acc (design, information about failed accounts)
- using this temple on both places
Merged into develop.
Updated by Radek Tomiška almost 7 years ago
- Due date set to 02/15/2018
- Start date changed from 09/25/2017 to 02/15/2018
- Follows Task #966: Send notification, with information about password was changed added