Task #692
closed
AbstractNotificationSender send by topic, level and type possible bug
Added by Ondřej Kopr over 7 years ago.
Updated about 7 years ago.
Description
Please check method send(String topic, IdmMessageDto message, List<IdmIdentityDto> recipients) in AbstractNotificationSender.
Template is not solved correctly. When create and send message with only filled topic (topic=some:example), was not found template by configuration.
configuration settings:
topic=some:example
level=null
type=email
If you have some problem with task consult with VS :-)
- Description updated (diff)
- Status changed from New to In Progress
- % Done changed from 0 to 50
How to simulate problem:
send notification to topic with two similar configurations, message should be sent twice..
IdmIdentityDto dto = identityService.getByUsername("testUser");
notificationManager.send("test", new IdmMessageDto.Builder().build(), dto);
Message will not be send because method resolveTemplate in class DefaultIdmNotificationTemplateService was not resolve wild card correctly.
I started with refactor this method and all AbstractNotificationSender api.
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 50 to 90
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
I did review, test and fixed some issues with sending duplicate notifications (configuration with different template).
Also available in: Atom
PDF