Task #680
closed
showLoading after approve task from mail
Added by Ondřej Kopr over 6 years ago. Updated over 6 years ago.
100%
Description
After approve task that has link from email or some notification, component for task approve has not history. router cant go back. Please fix this. If there is no history go to tasks list.
add into new hotfix + develop
Related issues
Updated by Ondřej Kopr over 6 years ago
- Status changed from New to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 0 to 90
goBack function from react router return undefined. More info https://github.com/ReactTraining/react-router/issues/408.
react router has not canGoBack yet, for check history is possible use 'history.length > 0', for hotfix is this problem fixed by add some check to undefined return value from goBack function.
I fixed this issue, approval task from link, disapprove task from link, go back button and non existing task url working correctly now.
Please Radek could you make a review? Thank you
This fix is already merged into hotfix/7.3.4 a develop
commit: https://github.com/bcvsolutions/CzechIdMng/commit/a424ac9b32fa38d84a98de2d305657193be06549
Updated by Ondřej Kopr over 6 years ago
I added the word for the nonexistent, or the already solved task.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/66971b4c8a4d141cf34361ad609f34435a52b102
This change is already merged into hotfix and develop.
Please Radek could you make a reReview? Thank you :)
Updated by Radek Tomiška over 6 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
I did review, its nice, thx!
Updated by Jan Helbich over 6 years ago
- % Done changed from 100 to 90
Does not work for me. Situation:
1. approved role is added to user -> creates approval task and sends notification to role guarantee
2. open anonymous window / logout + delete history
3. login -> click on the link from email notification
4. approve the task
The task gets approved all right, but afterwards I get redirected to an empty window (empty panel). This is definitely not a desired behavior. Can you please look into that?
Updated by Vít Švanda over 6 years ago
- Status changed from Closed to In Progress
Updated by Vít Švanda over 6 years ago
- Status changed from In Progress to Needs feedback
Updated by Ondřej Kopr over 6 years ago
- Assignee changed from Ondřej Kopr to Jan Helbich
I checked this behavior, problem is that you copy (ctrl+c,ctrl+v) url into your web browser directly. If you click to url in your email, you will be correctly redirect to all tasks/dashboard. Behavior you describe is correct some third party application may has some links to our application and when click go back (or etc.) you be redirected to third application. But if you have some bad experience with this behavior, is possible to consult and propose a better solution.
Updated by Ondřej Kopr over 6 years ago
- copy link with task url,
- get to google.com or etc,
- paste task link to as url and go to task,
- approve, disaprove or go back -> you will be redirected to google.com or etc...
Updated by Jan Helbich over 6 years ago
- Assignee changed from Jan Helbich to Ondřej Kopr
As we discussed a few weeks earlier, this behavior must be explicitly mentioned in wiki. Could you please write it if it hasn't been done already?
Otherwise its OK and this issue can be closed, thanks a lot!
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to Resolved
- % Done changed from 90 to 100
Documentation is already updated: https://wiki.czechidm.com/devel/dev/security/change-user-permissions#approve_disprove_task_by_task_detail
Updated by Radek Tomiška over 4 years ago
- Related to Defect #1926: Redirect after approve task on Firefox doesn't work added