Project

General

Profile

Actions
Copy link

Task #669

closed

Refactor role service to use dto

Added by Radek Tomiška over 6 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Roles
Target version:
Diamond (7.4.0)
Start date:
08/25/2017
Due date:
% Done:

100%

Estimated time:
Owner:

Description

Use IdmRoleDto in service (event processors) and controller layer.

Actions
Copy link
 #1

Updated by Radek Tomiška over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr
  • % Done changed from 0 to 90

Role agenda is refactored to dto usage, documentation:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/CHANGELOG.md#role

Could you pls do a feedback?

Actions
Copy link
 #2

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Ondřej Kopr to Radek Tomiška

This change is not backward compatible with existing workflow: ActivitiException: Unknown method used in expression: ${roleService.get(conceptRole.role).name}

Actions
Copy link
 #3

Updated by Ondřej Kopr over 6 years ago

Please maybe you missed refactor DefaultRoleConfiguration, now default role "idm.sec.core.role.default" not working :( please check this place, Thank you.

Actions
Copy link
 #4

Updated by Radek Tomiška over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Radek Tomiška to Ondřej Kopr

We will not hold backward compatibility for existing workflow processes. Processes have to be closed before update, i added it into version requirements:
https://github.com/bcvsolutions/CzechIdMng/blob/develop/CHANGELOG.md#requirements

I fixed loading role dto in configuration.

Could you do a feedback once again, pls?

Actions
Copy link
 #5

Updated by Ondřej Kopr over 6 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Radek Tomiška
  • % Done changed from 90 to 100

I did review everything that works with role works nice and smoothly.

After some test i get error wit stack overflow 

Caused by: com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError) (through reference chain: org.springframework.data.rest.webmvc.json.["content"]->eu.bcvsolutions.idm.core.model.entity.IdmRole["guarantees"]->java.util.ArrayList[0]->org.springframework.data.rest.webmvc.json.["content"]->eu.bcvsolutions.idm.core.model.entity.IdmRoleGuarantee["role"]-...

But this probably is unrelated with this changes and i'm not able to reproduce this error again.

Thank you for refactor roles to dtos, thank you!

Actions
Copy link
 #6

Updated by Radek Tomiška over 6 years ago

  • Status changed from Resolved to Closed

Thx for feedback, i added authority check to "save and add anothor" button.

Actions
Copy link

Also available in: Atom PDF