Task #669
closed
Refactor role service to use dto
Added by Radek Tomiška over 7 years ago.
Updated over 7 years ago.
Description
Use IdmRoleDto in service (event processors) and controller layer.
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 0 to 90
- Status changed from Needs feedback to In Progress
- Assignee changed from Ondřej Kopr to Radek Tomiška
This change is not backward compatible with existing workflow: ActivitiException: Unknown method used in expression: ${roleService.get(conceptRole.role).name}
Please maybe you missed refactor DefaultRoleConfiguration, now default role "idm.sec.core.role.default" not working :( please check this place, Thank you.
- Status changed from In Progress to Needs feedback
- Assignee changed from Radek Tomiška to Ondřej Kopr
- Status changed from Needs feedback to Resolved
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 90 to 100
I did review everything that works with role works nice and smoothly.
After some test i get error wit stack overflow
Caused by: com.fasterxml.jackson.databind.JsonMappingException: Infinite recursion (StackOverflowError) (through reference chain: org.springframework.data.rest.webmvc.json.["content"]->eu.bcvsolutions.idm.core.model.entity.IdmRole["guarantees"]->java.util.ArrayList[0]->org.springframework.data.rest.webmvc.json.["content"]->eu.bcvsolutions.idm.core.model.entity.IdmRoleGuarantee["role"]-...
But this probably is unrelated with this changes and i'm not able to reproduce this error again.
Thank you for refactor roles to dtos, thank you!
- Status changed from Resolved to Closed
Thx for feedback, i added authority check to "save and add anothor" button.
Also available in: Atom
PDF