Task #529
closed
Task agenda improvements
Added by Marcel Poul almost 7 years ago. Updated over 6 years ago.
100%
Description
Expected -
- I see all task, that I am or was involved in - included resolved tasks
- As administrator (helpdesk user), I see all tasks in the system - resolved and unresolved. I can filter in the table by the subjects, approvers, solved by user.
- Typical helpdesk issue. I approved the Task for my subordinate, but user still does not have e.g. role. Who is blocking the process?
- I want to check the state of the Task I originated or I was involved in
- administrator want to see the report of all unsolved tasks in system or by the user
Files
| who_requests.png (15.1 KB) who_requests.png | Marcel Poul, 01/16/2018 09:44 AM |
Updated by Marcel Poul almost 7 years ago
- Category changed from Workflow to Audit
- Assignee deleted (
Alena Peterová) - Target version set to Diamond (7.4.0)
Updated by Radek Tomiška over 6 years ago
- Category changed from Audit to Workflow
- Assignee changed from Radek Tomiška to Vít Švanda
Updated by Vít Švanda over 6 years ago
- Subject changed from task agenda improvements to Task agenda improvements
Updated by Ondřej Kopr over 6 years ago
- Assignee changed from Vít Švanda to Ondřej Kopr
Updated by Ondřej Kopr over 6 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 90
I implemented new agenda with all unresolved tasks. This agenda has new required permission for read: WORKFLOWTASK_ADMIN, also implemented new fields for filter: candidateOrAssigned, createdBefore, createdAfter. Original controller and service now has parent our abstract controller and service. Also WorkflowTaskInstanceDto has now parent BaseDto.
For read own tasks is now required permission WORKFLOWTASK_READ. The permission must be set to default user role (userRole).
Implementation can be found in branch: https://github.com/bcvsolutions/CzechIdMng/tree/okopr/529-task-agenda-improvements
commit: https://github.com/bcvsolutions/CzechIdMng/commit/4d247d21f94f0a5d35c308ac45491281baa7e686
Updated by Ondřej Kopr over 6 years ago
Please Vitek could you make a review?
Pull request: https://github.com/bcvsolutions/CzechIdMng/pull/13
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Vít Švanda
Updated by Marcel Poul over 6 years ago
- Assignee changed from Vít Švanda to Marcel Poul
After discussion with Ondra, I will do some basic UX testing
Updated by Marcel Poul over 6 years ago
- Assignee changed from Marcel Poul to Ondřej Kopr
Note: Implementation of this task does not involve the history of tasks. I shortly discussed this with Ondra and this is not easy to be implemented now, so I created a new ticket - Task #902.
Updated by Marcel Poul over 6 years ago
Two bugs to be addressed
- Cannot resolve the task unless I have EXECUTE permission
- Cannot see the status of the workflow and current implementers (on requests list).
I can retest then again. Thx
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to In Progress
Updated by Ondřej Kopr over 6 years ago
- % Done changed from 90 to 80
I resolved feedback from Marcel and Peter:
- I fixed localization (eq. Taks, message with permissions),
- table with tasks (dashboard) is now hidden when user doesn't has required permissions,
- add tasks permissions setup to doc: https://wiki.czechidm.com/devel/dev/security/authorization#examples_of_configuration
- add info about new tasks permission to changelog,
- add new permission to demo data.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/ef9fbb83d6c8d00d683a41b1f68f5b8db5c17aa5
The problem with hidden approvers in requests table is also in develop, I will fix the bug in this task.
Updated by Ondřej Kopr over 6 years ago
- % Done changed from 80 to 90
I fixed approvers in role request.
Commit: https://github.com/bcvsolutions/CzechIdMng/commit/18abd32a7301c19e86966f04920282c15d44c98f
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Marcel Poul
Please Marcel could you check this feature again? Thank you :)
Updated by Marcel Poul over 6 years ago
- File who_requests.png who_requests.png added
- Assignee changed from Marcel Poul to Ondřej Kopr
Hi Ondra,
I did a quick retest. It works fine, thanks.
- I am logged in as a user that the role change is REQUESTED FOR. I want to find who approves the request, I can't. - user 101. I am able to find it if I am logged in as admin - via subprocesses. This is more general feedback than bug in this ticket.
- When logged in as a user that approve the request, I cannot see the detail of applicant or the user that is requested for. This may be a problem of permissions in CzechIdM on the virtual server. see attached file.
Updated by Ondřej Kopr over 6 years ago
- Status changed from Needs feedback to In Progress
- % Done changed from 90 to 70
I checked status with develop and compare with my branch, on both branch is problem with show the main task (example: Change permissions request for ...) for user that is involved in task as requester hasn't chance see parent parent process. I will fixed this problem in this ticket.
Updated by Ondřej Kopr over 6 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Marcel Poul
- % Done changed from 70 to 90
It was fixed fill involved users and also fix show workflow processes
commit: https://github.com/bcvsolutions/CzechIdMng/commit/878c03813c8babbd350f1fd5251305e8908d86ee
Please Marcel could make a second review?
Updated by Ondřej Kopr over 6 years ago
I removed or in DefaultWorkflowHistoricTaskInstanceService search by involved user, this isn't needed more (I checked behavior with show ) and I added new tests for check task count.
commit: https://github.com/bcvsolutions/CzechIdMng/commit/b3458c2ff66ad2156d66a6f4f82b8aedf61b23ae
tests: https://github.com/bcvsolutions/CzechIdMng/commit/c7a6dcc9e6e36e1a570d21cff071934e826b0352
Updated by Ondřej Kopr over 6 years ago
- Assignee changed from Marcel Poul to Vít Švanda
Thanks Marcel for feedback I give the task to Vitek for code review and check refactor. Thanks.
Updated by Vít Švanda over 6 years ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Vít Švanda to Ondřej Kopr
- Target version set to Garnet (7.7.0)
- % Done changed from 90 to 100
I fixed:
- Pagination of the tasks.
- Complete of a task can execute only assign/candidate user.
- Decision buttons aren't returned from backend now (if user doesn't have the Execute permission).
- Permission "Task" translated as "Workflow task".
Updated by Radek Tomiška over 6 years ago
- Status changed from Resolved to Closed