Task #442
closed
Enable sms notifications to be marked "not sent"
100%
Description
Currently there is no way for custom implementations of AbstractSmsNotificationSender to tell rest of the application that some messages were not sent. Goal of this ticket is to do just that.
Related issues
Updated by Peter Štrunc over 7 years ago
- Related to Task #409: Mark notification as partially sent added
Updated by Peter Štrunc over 7 years ago
- % Done changed from 0 to 80
I implemented method sendSms on AbstractNotificationSender to return list of IdmSmsNotificationLog. Each log contains information about one sms for one NotificationRecipient. For now, these logs are merged into one to be consistent with rest of the application but later they will be all persisted (see #409).
Updated by Peter Štrunc over 7 years ago
- Status changed from New to Needs feedback
- Assignee changed from Peter Štrunc to Ondřej Kopr
Implemented in dbddc08c please someone provide review.
Updated by Ondřej Kopr over 7 years ago
- Assignee changed from Ondřej Kopr to Radek Tomiška
Updated by Radek Tomiška over 7 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
- Target version set to Citrine (7.3.0)
- % Done changed from 80 to 90
I did review and its ok, could be merged into develop, thx.
Notification api has to be redesigned in #409 (methods: N send(..., IdmIdentityDto recipient) => List<N> send(..., IdmNotificationRecipientDto recipient)). It will be useful for all senders without identity (email only, phone only etc.). Maybe some new manager will be created and currently used manager will be marked deprecated for compatibility issues.
Updated by Peter Štrunc over 7 years ago
- Status changed from In Progress to Closed
- % Done changed from 90 to 100