Project

General

Profile

Actions
Copy link

Task #432

closed

Rewrite workflow services (and REST controllers) to DTO services

Added by Vít Švanda almost 7 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Ondřej Kopr
Category:
Workflow
Target version:
Garnet (7.7.0)
Start date:
05/19/2017
Due date:
% Done:

100%

Estimated time:
Owner:
Actions
Copy link
 #1

Updated by Vít Švanda almost 7 years ago

  • % Done changed from 0 to 10

Start with transform controller and service for WrokflowProcessDefinition.

Actions
Copy link
 #2

Updated by Vít Švanda almost 7 years ago

  • % Done changed from 10 to 20

WrokflowProcessDefinition transformed. Five services remains.

Actions
Copy link
 #3

Updated by Vít Švanda over 6 years ago

  • Target version deleted (Diamond (7.4.0))
Actions
Copy link
 #4

Updated by Ondřej Kopr over 6 years ago

  • Assignee changed from Vít Švanda to Ondřej Kopr
Actions
Copy link
 #5

Updated by Ondřej Kopr over 6 years ago

WorkflowTaskInstanceService, WorkflowTaskInstanceController and now use correctly DTO layer. DTO WorkflowTaskInstanceDto now has parent BaseDto. I will continue with:
  • WorkflowProcessInstance,
  • WorkflowHistoricTaskInstance,
  • WorkflowHistoricProcessInstance.
Actions
Copy link
 #6

Updated by Ondřej Kopr over 6 years ago

  • % Done changed from 20 to 90
I refactored all WF services, controller and dtos to same state as rest of our dev stack. Check all tests on BE and test FE beahvior:
  • check WF agenda,
  • try deploy WF,
  • create new task,
  • approve task,
  • return task,
  • disapprove task.

I resolved issue with react router (now we have two path for tasks: /tasks/identity, /tasks/all and /task/<id> for detail), when we get to task detail from some url we don't know which address to go to.

Actions
Copy link
 #7

Updated by Ondřej Kopr over 6 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Ondřej Kopr to Vít Švanda

Solution can be found there: https://github.com/bcvsolutions/CzechIdMng/tree/okopr/529-task-agenda-improvements
In same branch is also task #529

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/b59d53e289a3d7cf5987a5839021763110c8e761
Pull request: https://github.com/bcvsolutions/CzechIdMng/pull/13

Vitek could you make a review? I left all search methods in services and also I don't change logic in this methods, so API's for WF services are same as before, I marked page attributes in WorkflowFilterDto filter as deprecated.

Actions
Copy link
 #8

Updated by Vít Švanda about 6 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Vít Švanda to Ondřej Kopr
  • Target version set to Garnet (7.7.0)
I did review and test. Works fine. Thanks for that.
I fixed:
  • I changed "collectionRelation" back to the value "resources" ... for compatibility.
  • Pagination of the tasks, processes, history.
  • Complete of a task can execute only assign/candidate user.
  • Ondra, please create some test for check "complete task". Only assigne/candiate can execute/complete the task. Not Owner, not Starter, not Participant. After that you can resolve this task.
Actions
Copy link
 #9

Updated by Vít Švanda about 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 90 to 100
Actions
Copy link

Also available in: Atom PDF