Defect #417
closed
Filter on tree nodes by parent tree node fails
Added by Radek Tomiška about 7 years ago.
Updated almost 7 years ago.
Description
After filter were moved to api and refactored (entity -> uuid) filter on tree nodes by parent tree node fails. Please check other refactored filters too.
- Status changed from New to In Progress
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Ondřej Kopr
- % Done changed from 0 to 70
I fixed the problem and implemented a test that should cover it for the future. I did it by implementing find method on IdmTreeNodeService which now uses Criteria API instead of JPQL query. Old method on IdmTreeNodeRepository is marked deprecated, but it is not fixed since it will be removed anyway.
Ondra, please do review. Implementation is in psourek/filter-fix branch.
- Assignee changed from Ondřej Kopr to Radek Tomiška
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Peter Štrunc
- % Done changed from 70 to 100
It works and code looks fine. Rewriting find method from HQL to criretia JPA is nice - we had to do it eventually, so you killed two flies with one punch :)
I've made some small refactoring (remove find method impl from repository, spliting rest and integration tests, unused imports, add authors etc.) and i've merged psourek/filter-fix branch into develop.
Thx.
- Status changed from Closed to In Progress
- Assignee changed from Peter Štrunc to Radek Tomiška
I fixed like search in queries. I also added test to cover this case. Please give me feedback, thanks. It is in commit f100e6130bd.
- Status changed from In Progress to Needs feedback
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
Ok (review only), merge it please to develop.
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Radek Tomiška
I fixed the corrupted test in commit 13b75c17d1788. Please look at it so develop will become stable again.
Ok (review only), merge it please to develop.
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Peter Štrunc
- Status changed from In Progress to Closed
- Copied to Defect #450: Tree structure in GUI error added
Also available in: Atom
PDF
