Task #345
closed
New component for hide large text
Added by Ondřej Kopr about 7 years ago.
Updated almost 7 years ago.
Description
Create new component for hide large amount of text wiht dot.
Example description :
Before:
Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.
After:
Lorem ipsum dolor sit amet...
props: max, ... ??
This compoenet may also show path in organization structure (identity contract nice label) - ( org_root / some_node / etc ... )
Example organization path:
Before:
org_root / some_node / etc / last_node
After:
... etc / last_node
Props same as max, or max depth?
- Assignee changed from Ondřej Kopr to Marek Klement
- Category set to Frontend
- Status changed from New to Needs feedback
- Target version set to Citrine (7.3.0)
- % Done changed from 0 to 80
Implemented and is located in branch klementm/345-hide-large-text
- Assignee changed from Marek Klement to Radek Tomiška
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Marek Klement
I did review:
- readme is nice, only pasted DateValue is forgotten
- reuse some new method in original UiUtils.substringByWord (if it's possible).
- @author annotation is missing in newly added components
- documentation says "All parameters from AbstractComponent are supported" but it's not :) Implement rendered and showLoading property (showLoading is maybe not needed)
- rename component to ShortText (this is discutable, but we like it more and its shorter:))
- show full text in component's title (maybe Basic.Tooltip could be used)
- rename property maxLen to maxLength (we don't use abbreviations as possible)
- tests are nice, you can use jsDoc instead "- load module components" - when test failed, this text will be show in now will be shown still the same text.
- Status changed from In Progress to Needs feedback
- Assignee changed from Marek Klement to Radek Tomiška
- % Done changed from 80 to 90
I made changes from review. It does support rendered now but does not support showLoading. Tooltips also used for showing text.
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Marek Klement
- % Done changed from 90 to 100
I did test and review and minor corrections (default rendered is true, "- load module components" removed from tests ...). It works smoothly, thx.
I merged branch into develop.
Also available in: Atom
PDF
