Task #3399
closed
Notification before recertification ends
Added by Luboš Čábelka over 1 year ago.
Updated about 1 year ago.
Description
Goal of this ticket is to change notification before certification ends.
- Notification can be send to manager of notification approver, or helpdesk - recipients can be changed using script.
- One recipient can get only 1 notification with information about all recertification tasks for him.
- % Done changed from 0 to 70
- Assignee changed from Luboš Čábelka to Ondřej Kopr
- % Done changed from 70 to 90
- Assignee changed from Ondřej Kopr to Luboš Čábelka
- % Done changed from 90 to 70
I made code review. Code looks good! I just found some minor things that is just nice to have or not? :D :
- class RecertificationScriptUtils doesnt include author and description,
- recertificationInfos in notification recertificationDueDateWarning isnt used in product notification (maybe for example of use - or include example into documentation),
- info isn't probably countable noun - plural infos doesn't exist,
- tests missing.
Thanks for this nice feature. Included script is nice idea!
- % Done changed from 70 to 90
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF
