Actions
Task #3399
closed
Notification before recertification ends
Start date:
06/20/2023
Due date:
% Done:
100%
Estimated time:
Owner:
Description
Goal of this ticket is to change notification before certification ends.
- Notification can be send to manager of notification approver, or helpdesk - recipients can be changed using script.
- One recipient can get only 1 notification with information about all recertification tasks for him.
Updated by Luboš Čábelka 10 months ago
- % Done changed from 0 to 70
Updated by Luboš Čábelka 10 months ago
- Assignee changed from Luboš Čábelka to Ondřej Kopr
- % Done changed from 70 to 90
Final version is in branch https://git.bcvsolutions.eu/modules/recertification/-/commits/lcabelka/3399-merge-branch
With merged force recertifications.
@kopro can you review it please?
Updated by Ondřej Kopr 10 months ago
- Assignee changed from Ondřej Kopr to Luboš Čábelka
- % Done changed from 90 to 70
I made code review. Code looks good! I just found some minor things that is just nice to have or not? :D :
- class RecertificationScriptUtils doesnt include author and description,
- recertificationInfos in notification recertificationDueDateWarning isnt used in product notification (maybe for example of use - or include example into documentation),
- info isn't probably countable noun - plural infos doesn't exist,
- tests missing.
Thanks for this nice feature. Included script is nice idea!
Updated by Luboš Čábelka 10 months ago
- % Done changed from 70 to 90
- Description added into class
- recertificationInfos removed completely (forgotten from implementation).
- Added junit tests for new parameters and util class.
All in commit: https://git.bcvsolutions.eu/modules/recertification/-/commit/a7d01c7bde583b86ec12d25b195ce48c09143a9d
Actions