Task #3399: Notification before recertification ends - Recertification (rec) - IdStory Identity Manager

Actions

Task #3399

closed

Added by Luboš Čábelka over 1 year ago. Updated about 1 year ago.

Status:

Closed

Priority:

Normal

Assignee:

Luboš Čábelka

Target version:

Start date:

06/20/2023

Due date:

% Done:

100%

Estimated time:

Owner:

Description

Goal of this ticket is to change notification before certification ends.

Notification can be send to manager of notification approver, or helpdesk - recipients can be changed using script.
One recipient can get only 1 notification with information about all recertification tasks for him.

Actions

Actions

Final version is in branch https://git.bcvsolutions.eu/modules/recertification/-/commits/lcabelka/3399-merge-branch
With merged force recertifications.
@kopro can you review it please?

Actions

I made code review. Code looks good! I just found some minor things that is just nice to have or not? :D :

class RecertificationScriptUtils doesnt include author and description,
recertificationInfos in notification recertificationDueDateWarning isnt used in product notification (maybe for example of use - or include example into documentation),
info isn't probably countable noun - plural infos doesn't exist,
tests missing.

Thanks for this nice feature. Included script is nice idea!

Actions