Task #334
closed
Long running task - account management
Added by Radek Tomiška about 7 years ago.
Updated about 7 years ago.
Category:
Account managment
Description
Role could be assigned with future validity - when role will be valid, then account management (and provisioning) should be executed => new accounts for newly valid roles has to be created.
- % Done changed from 0 to 50
Implementation detail:
- Create new 'queue' IdmIdentityRoleValidRequest that store all non valid identity role request,
- new long running task that iterate over all found IdmIdentityRoleValidRequest that will be valid from now (today, new LocalDate),
- new proccesor for IdmIdentityRoleValidRequest with process IDENTITY_ROLE_VALID.
- Status changed from New to Needs feedback
- % Done changed from 50 to 90
Create test:
- for Acc processor IdentityRoleValidRequestProvisioningProcessor,
- for referential integrity (core module).
save into IdentityRoleValidRequest move into identityRoleSaveProcessor.
Update ER diagram.
Radek please do code review thank you very much.
- Assignee changed from Ondřej Kopr to Radek Tomiška
Now service, processor use DTOs. Fix test - use future task instead of wait for.
Please Radek, could you make review? Thank you.
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
I did test and review, it works nice, good job. I found some minor issues:
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
method (isIdentityRoleValidFromNow) from service IdmIdentityRoleService was removed and add new method into entity IdmIdentityRole (add two constant with MIN and MAX date time to ValidableEntity),
add some information about new queue and long running task.
Please check newly created constant and method isValid in IdmIdentityRole, thank you Radek.
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
Remove MIN and MAX from ValidableEntity please and check null values instead :)
After this, you could close this ticket .)
Remove constants and inside method isValid call method from EntityUtils.isValid.
- Status changed from In Progress to Resolved
- % Done changed from 90 to 100
- Status changed from Resolved to Closed
Also available in: Atom
PDF