Feature #3348
closed
Implement account management for technical acounts
Added by Peter Štrunc over 1 year ago.
Updated about 1 year ago.
Description
Parts of the account management are already implemented, such as TechnicalAccountProvisioningExecutor, but AccountManagementService, and some processors still rely on identity provisioning and cannot handle other types of account owners. This results in some weird issues, such as provisioning not being invoked when new roles are assigned to technical accounts and so on.
The goal of this ticket is to clean up the rough parts of technical account provisioning and account management and implement missing stuff.
- Target version changed from 1.0.2 to 1.1.0
- Sprint set to Sprint 13.0.5 - 1 (May 03 - May 17)
- Status changed from New to In Progress
- Status changed from In Progress to Resolved
- Status changed from Resolved to In Progress
- Sprint changed from Sprint 13.0.5 - 1 (May 03 - May 17) to Sprint 13.0.5 - 2 (May 17 - May 29)
- % Done changed from 0 to 70
- Sprint changed from Sprint 13.0.5 - 2 (May 17 - May 29) to Sprint 13.0.5 - 3 (May 29 - Jun 12)
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Ondřej Kopr
- % Done changed from 70 to 80
- Owner set to Peter Štrunc
- Status changed from Needs feedback to Resolved
- Assignee changed from Ondřej Kopr to Peter Štrunc
- % Done changed from 80 to 100
I made code review - LGTM! Thanks for abstraction service a processors.
I just found one thing that is probably only about understanding the code.
Processors AbstractRoleAssignmentDeleteAccountProcessor has order -900 (before delete). Original processor for identity role (IdentityRoleDeleteAccountProcessor) had -1000 did you want order -900, 100 or original -1000.
It is just minor thing, or question.
Otherwise everything else looks good!
Good point, I returned the processor order back.
- Status changed from Resolved to Closed
Also available in: Atom
PDF