Project

General

Profile

Actions
Copy link

Feature #3348

closed

Implement account management for technical acounts

Added by Peter Štrunc over 1 year ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Peter Štrunc
Target version:
1.1.0
Start date:
04/28/2023
Due date:
% Done:

100%

Estimated time:
Owner:
Peter Štrunc

Description

Parts of the account management are already implemented, such as TechnicalAccountProvisioningExecutor, but AccountManagementService, and some processors still rely on identity provisioning and cannot handle other types of account owners. This results in some weird issues, such as provisioning not being invoked when new roles are assigned to technical accounts and so on.

The goal of this ticket is to clean up the rough parts of technical account provisioning and account management and implement missing stuff.

Actions
Copy link
 #1

Updated by Peter Štrunc over 1 year ago

  • Target version changed from 1.0.2 to 1.1.0
Actions
Copy link
 #2

Updated by Peter Štrunc over 1 year ago

  • Sprint set to Sprint 13.0.5 - 1 (May 03 - May 17)
Actions
Copy link
 #3

Updated by Peter Štrunc over 1 year ago

  • Status changed from New to In Progress
Actions
Copy link
 #4

Updated by David Štekl over 1 year ago

  • Status changed from In Progress to Resolved
Actions
Copy link
 #5

Updated by David Štekl over 1 year ago

  • Status changed from Resolved to In Progress
Actions
Copy link
 #6

Updated by Peter Štrunc over 1 year ago

  • Sprint changed from Sprint 13.0.5 - 1 (May 03 - May 17) to Sprint 13.0.5 - 2 (May 17 - May 29)
Actions
Copy link
 #7

Updated by Peter Štrunc over 1 year ago

  • % Done changed from 0 to 70
Actions
Copy link
 #8

Updated by Peter Štrunc over 1 year ago

  • Sprint changed from Sprint 13.0.5 - 2 (May 17 - May 29) to Sprint 13.0.5 - 3 (May 29 - Jun 12)
Actions
Copy link
 #9

Updated by Peter Štrunc over 1 year ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Peter Štrunc to Ondřej Kopr
  • % Done changed from 70 to 80
  • Owner set to Peter Štrunc
Actions
Copy link
 #10

Updated by Ondřej Kopr over 1 year ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Ondřej Kopr to Peter Štrunc
  • % Done changed from 80 to 100

I made code review - LGTM! Thanks for abstraction service a processors.

I just found one thing that is probably only about understanding the code.

Processors AbstractRoleAssignmentDeleteAccountProcessor has order -900 (before delete). Original processor for identity role (IdentityRoleDeleteAccountProcessor) had -1000 did you want order -900, 100 or original -1000.

It is just minor thing, or question.

Otherwise everything else looks good!

Actions
Copy link
 #11

Updated by Peter Štrunc over 1 year ago

Good point, I returned the processor order back.

Actions
Copy link
 #12

Updated by Peter Štrunc about 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF