Project

General

Profile

Actions
Copy link

Defect #3248

closed

Business role composition cannot be removed if the super role is not assigned to anyone

Added by Alena Peterová almost 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Tomáš Doischer
Category:
Roles
Target version:
13.0.1
Start date:
01/27/2023
Due date:
% Done:

100%

Estimated time:
Affected versions:
12.2.4
Owner:

Description

Tested on 12.2.3 and 13.0.0 RC
Steps to reproduce:
  • Create "superrole" and "subrole" composition
  • Try to remove the subrole from the superrole
  • The subrole is not removed. The task Delete business role (RemoveRoleCompositionTaskExecutor) was started and no error.
Workaround:
  • Assign the superrole to some user
  • Try to remove the subrole from the superrole
  • The removal is successful

    Audit:

Files

Download all files
rolecomposition_audit.png (34.6 KB) rolecomposition_audit.png Alena Peterová, 01/27/2023 11:18 AM
removebusinessrole.png (74.8 KB) removebusinessrole.png Alena Peterová, 01/27/2023 11:18 AM
superrole.png (38.2 KB) superrole.png Alena Peterová, 01/27/2023 11:22 AM
Actions
Copy link
 #1

Updated by Alena Peterová almost 2 years ago

Note: when deleting the whole "superrole" using force delete, the role composition is removed successfully together with the role, even though there is no role assignment.

Actions
Copy link
 #2

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Tomáš Doischer
Actions
Copy link
 #3

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Peter Štrunc
  • % Done changed from 0 to 80

Fixed. There was an issue with commiting the transaction. Not really sure why this happened when the role was not assigned.

PR: https://github.com/bcvsolutions/CzechIdMng/pull/339

Actions
Copy link
 #4

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Peter Štrunc to Tomáš Doischer
  • % Done changed from 80 to 60

One test failed, will take a look at it.

Actions
Copy link
 #5

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Tomáš Doischer to Peter Štrunc
  • Target version set to 13.1.0
  • % Done changed from 60 to 80

The original solution led to some issues with transactions. I instead implemented BE delete bulk action for role composition. This is desirable anyway and works nice.

@sourek, can you please take a look at it?

Actions
Copy link
 #6

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Peter Štrunc to Tomáš Doischer
  • % Done changed from 80 to 100

Merged to develop.

Actions
Copy link
 #7

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 13.1.0 to 13.0.1
Actions
Copy link

Also available in: Atom PDF