Feature #3171
closed
Owner tab on system detail
Added by Roman Kučera almost 2 years ago. Updated over 1 year ago.
100%
Description
Add tab on system detail
It will be same component as in another places (guarantee by identity/role) only in this case the labeling will be owners.
Use the new/improved component or the current one
Related issues
Updated by Roman Kučera almost 2 years ago
- Related to Feature #3172: Improve component with guarantors based on role added
Updated by Tomáš Doischer over 1 year ago
- Sprint set to Sprint 12.3-1 (srp 03 - srp 17)
- Assignee set to Evgeniya Gorina
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-1 (srp 03 - srp 17) to Sprint 12.3-2 (srp 17 - srp 31)
Updated by Tomáš Doischer over 1 year ago
- Status changed from New to In Progress
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-2 (srp 17 - srp 31) to Sprint 12.3-3 (srp 31 - zář 14)
Updated by Evgeniya Gorina over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Evgeniya Gorina to Roman Kučera
Can you give me feedback
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-3 (srp 31 - zář 14) to Sprint 12.3-4 (zář 14 - zář 28)
Updated by Roman Kučera over 1 year ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Roman Kučera to Evgeniya Gorina
I did code review.
Please look at commends in PR https://github.com/bcvsolutions/CzechIdMng/pull/261 there are only minor things.
Next I will test it in the meantime.
Updated by Roman Kučera over 1 year ago
I tested it and it works nicely.
I noticed only one small thing. When I add new owner by identity or by role there is no pop-up green message about that.
When I am deleting record green pop-up is displayed correctly.
After mentioned fixes from ticket and PR I will test again with permission, right now it was tested as superadmin.
Updated by Evgeniya Gorina over 1 year ago
- Assignee changed from Evgeniya Gorina to Roman Kučera
- % Done changed from 60 to 70
I have done changes on your comments, could you check it one more time please
Updated by Roman Kučera over 1 year ago
- Assignee changed from Roman Kučera to Evgeniya Gorina
@gorinae I did review, almost everything was fixed, but there are still some things to fix. Please look at PR.
Updated by Tomáš Doischer over 1 year ago
- Sprint changed from Sprint 12.3-4 (zář 14 - zář 28) to Sprint 12.3-5 (zář 28 - říj 12)
Updated by Evgeniya Gorina over 1 year ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Evgeniya Gorina to Roman Kučera
Could you check it again pleas, I have done all your comments and added green popup, even have no idea how I could forget it about
Updated by Roman Kučera over 1 year ago
- Status changed from Needs feedback to Resolved
- Assignee changed from Roman Kučera to Evgeniya Gorina
- % Done changed from 70 to 100
LGTM, merged
Updated by Tomáš Doischer over 1 year ago
- Status changed from Resolved to Closed