Task #312
closed
Role catalogue
Added by Ondřej Kopr about 7 years ago. Updated about 7 years ago.
100%
Description
- add tree structure to role catalogues
- add N-M connections to role
- Nice name (unique), unique.
- description
- technical name / id
- URL - clickable url, (external url)
Related issues
Updated by Ondřej Kopr about 7 years ago
- % Done changed from 0 to 90
- Add new entity IdmRoleCatalogueRole (intersection table between role and role catalogue),
- add new attributes for role catalogue,
- fix repositories, filters,
- add some new test.
Please do review, thank you very much.
Updated by Ondřej Kopr about 7 years ago
After discussion with ZB do some mirror changes:
- technical name is same as simple name,
- technical name is CODE,
- nice labale for role catalogue = User name (code),
- change some labels in roles.
Updated by Ondřej Kopr about 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- % Done changed from 60 to 90
Please check FE and do some code review :) thank you :)
Updated by Zdeněk Burda about 7 years ago
BUG1: nelze se dostat k rolím, které nejsou v katalogu
Příprava prostředí:
Čistá instalace ("demo" s h2).
Vytvořím v "Nastavení->Katalog rolí" položku katalogu "xxx"
Jak vyvolat chybu:
Kliknu v menu na "Role" a vidím seznam rolí a nově vytvořenou položku katalogu . Kliknu na položku katalogu "xxx", v pravé části stránky se místo seznamu rolí vypíše "Nenalezeny žádné záznamy". To je OK. Ale teď už nemám žádnou možnost jak se dostat k seznamu rolí, které nejsou v katalogu zařazené.
BUG2: mix různých názvů pro jednu věc
Při vytváření položky katalogu v "Nastavení->Katalog rolí" je dialog pro vytvoření pojmenován "Nová složka", ale label inputboxu je "Jméno katalogu", navrhuji sjednotit a pojmenovávat to jako složku. Katalog máme jen jeden, ten má víc složek.
Updated by Ondřej Kopr about 7 years ago
Review:
EN:
BUG #1: component Tree in role and tree node agendas is used as filter, so you must cancel filter for show all roles. This is same behavior as nodes.
BUG #2: i will changed all 'folders' to 'catalogue'.
CZ:
BUG #1: Komponenta tree v agendách role a stromové struktury je používána jako filter, takže pokud chceš zobrazit všechny role musíš zrušit filtr. Stejné chování jako na stromových strukturách.
BUG #2: Změním všechnz 'složky' na 'katalogy'.
Updated by Radek Tomiška about 7 years ago
Add bug#1: this feature will be improved by #316, when all children will be shown (through tree structure down) => forest index has to be used for role catalogues too.
Updated by Radek Tomiška about 7 years ago
- Related to Task #316: Indexed tree structure added
Updated by Radek Tomiška about 7 years ago
- Status changed from Needs feedback to In Progress
- Assignee changed from Radek Tomiška to Ondřej Kopr
I've added forest index to role catalogues and did review.
I found just minor issues:- localization for error codes is missing (e.g. ROLE_CATALOGUE_BAD_PARENT)
- move localization keys from entity to content (+filter.code is mising)
Updated by Ondřej Kopr about 7 years ago
- Status changed from In Progress to Needs feedback
- Assignee changed from Ondřej Kopr to Radek Tomiška
- Add filter localization to content,
- localization error messages.
Thank you for your feedback.
Updated by Radek Tomiška about 7 years ago
- Status changed from Needs feedback to Closed
- Assignee changed from Radek Tomiška to Ondřej Kopr
- % Done changed from 90 to 100
Its nice, thx.