Project

General

Profile

Actions

Task #3067

closed

Material UI - improvements

Added by Peter Štrunc almost 3 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Evgeniya Gorina
Category:
Frontend
Target version:
Start date:
02/21/2022
Due date:
% Done:

100%

Estimated time:
Owner:

Description

After we started using material-ui components, some UI elements changed their behavior. This ticket is a collection of minor changes, which should be undone since version 12.0.0


Files

scrollbar.png (45.5 KB) scrollbar.png Peter Štrunc, 02/21/2022 12:14 PM
delete.png (87.9 KB) delete.png Roman Kučera, 02/23/2022 08:22 AM
script.png (39.1 KB) script.png Roman Kučera, 02/23/2022 08:22 AM
text_areas.png (44.1 KB) text_areas.png Vladimír Kotýnek, 03/15/2022 09:16 AM
resize.png (412 Bytes) resize.png Vladimír Kotýnek, 03/15/2022 09:17 AM
search_field.png (4.37 KB) search_field.png Vladimír Kotýnek, 03/21/2022 08:53 AM
logo.png (3.9 KB) logo.png Vladimír Kotýnek, 03/22/2022 12:10 PM
Main_scrollbar_desktop.jpg (65.6 KB) Main_scrollbar_desktop.jpg Evgeniya Gorina, 08/19/2022 07:39 AM
Delete_user_with_a_gap.jpg (32.1 KB) Delete_user_with_a_gap.jpg Evgeniya Gorina, 08/19/2022 07:42 AM
Script_lable_hidden.jpg (109 KB) Script_lable_hidden.jpg Evgeniya Gorina, 08/19/2022 07:42 AM
Copy_wrap_buttons_scrollbar_horisontal.jpg (131 KB) Copy_wrap_buttons_scrollbar_horisontal.jpg Evgeniya Gorina, 08/19/2022 07:50 AM
popup_with_copyed_notice.jpg (212 KB) popup_with_copyed_notice.jpg Evgeniya Gorina, 08/19/2022 07:53 AM

Related issues

Related to IdStory Identity Manager - Defect #3066: Main menu has it's own scrollbar when a submenu is expandedClosedBoris Polák02/21/2022

Actions
Related to IdStory Identity Manager - Defect #3102: Resizable textareaClosedRoman Kučera04/12/2022

Actions
Actions #1

Updated by Peter Štrunc almost 3 years ago

Scrollbar on main navigation

Since version 12.0.0, main navigation is scrollable independently of the rest of the page. This should not be the case.

Actions #2

Updated by Vladimír Kotýnek almost 3 years ago

  • Related to Defect #3066: Main menu has it's own scrollbar when a submenu is expanded added
Actions #3

Updated by Alena Peterová almost 3 years ago

Required fields are no longer highlighted red, only the asterisk is present. This is more easy to overlook.

Actions #4

Updated by Roman Kučera almost 3 years ago

delete user bulk action has wrong spacing

script label is covering first line

Actions #5

Updated by Vladimír Kotýnek almost 3 years ago

Text areas e.g. with Exceptions or EAV cannot be resized in browser (tested in Vivaldi). There used to be in the bottom-right corner of the text area

Edit: moved to #3102.

Actions #6

Updated by Vladimír Kotýnek almost 3 years ago

Implrove global search field description and background color to be more contrasting. Especially when I change primary color.

Edit: moved to #3106.

Actions #7

Updated by Vladimír Kotýnek almost 3 years ago

Logo on login-page has green background. In the rest of the application the logo has a white background so it's usually optimised for that.

Actions #8

Updated by Roman Kučera over 2 years ago

Actions #9

Updated by Tomáš Doischer over 2 years ago

The exceptions field can still be difficult to use. The lines are long and cannot be scrolled.

Our suggestion is:
  1. add the option to change line breaks and enable horizontal scrolling in the component
  2. add a button that will save the field content to the clipboard
  3. change the field from disabled to normal state and style it separately (some browser won't let you interact with a disabled element)

The combination of these should solve all issues.

Actions #10

Updated by Tomáš Doischer over 2 years ago

  • Sprint set to Sprint 12.3-1 (srp 03 - srp 17)
  • Assignee changed from Peter Štrunc to Evgeniya Gorina
Actions #11

Updated by Tomáš Doischer over 2 years ago

  • Sprint changed from Sprint 12.3-1 (srp 03 - srp 17) to Sprint 12.3-2 (srp 17 - srp 31)
Actions #12

Updated by Evgeniya Gorina over 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50
Actions #13

Updated by Evgeniya Gorina over 2 years ago

Peter Štrunc wrote in #note-1:

Scrollbar on main navigation

Since version 12.0.0, main navigation is scrollable independently of the rest of the page. This should not be the case.

Evgeniya Gorina wrote:

Main sidebar without own scrollbar

Actions #14

Updated by Evgeniya Gorina over 2 years ago

Peter Štrunc wrote in #note-1:

Scrollbar on main navigation

Since version 12.0.0, main navigation is scrollable independently of the rest of the page. This should not be the case.

Peter Štrunc wrote in #note-1:

Scrollbar on main navigation

Since version 12.0.0, main navigation is scrollable independently of the rest of the page. This should not be the case.

Actions #15

Updated by Evgeniya Gorina over 2 years ago

Roman Kučera wrote in #note-4:

delete user bulk action has wrong spacing

script label is covering first line

Evgeniya Gorina wrote:

Delete user with a spacing

Script label was hidden

Actions #16

Updated by Evgeniya Gorina over 2 years ago

Tomáš Doischer wrote in #note-9:

The exceptions field can still be difficult to use. The lines are long and cannot be scrolled.

Our suggestion is:
  1. add the option to change line breaks and enable horizontal scrolling in the component
  2. add a button that will save the field content to the clipboard
  3. change the field from disabled to normal state and style it separately (some browser won't let you interact with a disabled element)

The combination of these should solve all issues.

Evgeniya Gorina wrote:

Horizontal scrolling was added by button with the options open and close the scrollbar

Button clipboard was added with popup for make an announce that content was copied

Actions #17

Updated by Evgeniya Gorina over 2 years ago

  • % Done changed from 50 to 70
Actions #18

Updated by Evgeniya Gorina over 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Evgeniya Gorina to Tomáš Doischer
Actions #19

Updated by Tomáš Doischer over 2 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Tomáš Doischer to Evgeniya Gorina

Thank you for the improvements, it looks much better now.

I have some notes from the review, see the PR.

Actions #20

Updated by Evgeniya Gorina over 2 years ago

  • Sprint changed from Sprint 12.3-2 (Aug 17 - Aug 31) to Sprint 12.3-1 (Aug 03 - Aug 17)
  • % Done changed from 70 to 0
Actions #21

Updated by Tomáš Doischer over 2 years ago

  • Sprint changed from Sprint 12.3-1 (srp 03 - srp 17) to Sprint 12.3-3 (srp 31 - zář 14)
Actions #22

Updated by Evgeniya Gorina over 2 years ago

  • % Done changed from 0 to 60
Actions #23

Updated by Evgeniya Gorina over 2 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Evgeniya Gorina to Tomáš Doischer
  • % Done changed from 60 to 70

Can you give me feedback please

Actions #24

Updated by Tomáš Doischer over 2 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Tomáš Doischer to Evgeniya Gorina
  • % Done changed from 70 to 100

LGTM, thank you, merged to develop.

Actions #25

Updated by Tomáš Doischer almost 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF