IdStory IdM modules » sms

• Option to set the sender address = should be possible via standard app config for emailer
• Subject of email is the SMS body = possible via standard template config
• Body of email empty = possible via standard template config

Implementation https://git.bcvsolutions.eu/modules/sms/-/commits/3043-email-sms-sender

All is implemented. Only thing is that when sms(email) is send error message in log is shown because email log has no uuid. There is no way how to fix it from the side of module.
Only way how to fix is in product EmailCallback class inside DefaultEmailer and add some check if uuid is null or not.

Added to the documentation: https://wiki.czechidm.com/tutorial/adm/modules_sms

Tested in the environment of our customer.
When dealing with phone numbers, we have to remove whitespace: https://git.bcvsolutions.eu/modules/sms/-/commit/37594c91b5a510335b9c4b6c41d67d5268377691.
Otherwise, it works fine in our case.
There is a little catch that only prefixes that are removed from phone numbers are Czech 420 and Slovak 421. It would be more universal to remove other prefixes too, or make it a configuration property. However, I think it's enough for now.

Note:
There is only the issue mentioned above #3043#note-5, which currently doesn't have solution. The application log always displays error:

2023-08-18 15:33:15.450 ERROR 510945 --- [Camel (camel-1) thread #0 - ProducerTemplate] e.b.i.c.n.s.impl.DefaultEmailer.onComplete : Unspecified error while save emailLog, with id: [null].
org.springframework.dao.InvalidDataAccessApiUsageException: The given id must not be null!; nested exception is java.lang.IllegalArgumentException: The given id must not be null!
    at org.springframework.orm.jpa.EntityManagerFactoryUtils.convertJpaAccessExceptionIfPossible(EntityManagerFactoryUtils.java:373)
...