Task #2992
closed
Add support for skipping automatic role recalculation in SaveAllNodesForSubtreeExecutor
Added by Peter Štrunc about 3 years ago.
Updated about 3 years ago.
Description
Calculating automatic roles on each contract save becomes very slow when there is a lot of automatic role rules. It is more beneficial to skip calculating these roles and schedule automatic role recalculation separately after tree node sync is finished.
Also, it would be better to implement this lrt as a stateful task so that we can see which contracts are being processed.
- Status changed from New to In Progress
- % Done changed from 0 to 70
- Status changed from In Progress to Needs feedback
- Assignee changed from Peter Štrunc to Tomáš Doischer
- % Done changed from 70 to 80
- Status changed from Needs feedback to In Progress
- Assignee changed from Tomáš Doischer to Peter Štrunc
Thanks for this. I only did code review (no testing) but the test looks good. I found only minor issues:
- supportQueue needs to be overriden to false
- documentation does not really say what the whole feature is for
- localization is missing for LRTs (and result code - but it is probably not needed) - I know that this will likely not be ran manually but it will be shown among other tasks
The code looks good otherwise.
- Status changed from In Progress to Closed
- % Done changed from 80 to 100
Thanks @doischert, I added localization and disabled queue for these tasks.
Also available in: Atom
PDF
