Project

General

Profile

Actions
Copy link

Defect #2620

closed

Wizard: missing conntector images

Added by Radek Tomiška about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Radek Tomiška
Category:
Wizard
Target version:
10.7.1
Start date:
12/18/2020
Due date:
% Done:

100%

Estimated time:
Affected versions:
10.7.0
Owner:

Description

Connector images missing in build (~release).
Reason: developer 'img' path is used in icon components.
Solution: Css background for images (e.g. flag component used in navigation)

Files

missing-wizard-icons.png (21.9 KB) missing-wizard-icons.png Radek Tomiška, 12/18/2020 10:58 AM

Related issues

Related to IdStory Identity Manager - Task #2528: Wizard - Implement connector templates.ClosedVít Švanda10/21/2020

Actions
Related to IdStory Identity Manager - Feature #2621: FE: Support images from custom moduleNewRadek Tomiška12/18/2020

Actions
Related to IdStory Identity Manager - Defect #2631: CSV wizard - missing IdM logoClosedRadek Tomiška01/07/2021

Actions
Actions
Copy link
 #1

Updated by Radek Tomiška about 4 years ago

Actions
Copy link
 #2

Updated by Radek Tomiška about 4 years ago

  • Description updated (diff)
Actions
Copy link
 #3

Updated by Radek Tomiška about 4 years ago

  • Related to Task #2528: Wizard - Implement connector templates. added
Actions
Copy link
 #4

Updated by Radek Tomiška about 4 years ago

  • Related to Feature #2621: FE: Support images from custom module added
Actions
Copy link
 #5

Updated by Radek Tomiška about 4 years ago

  • Status changed from New to Needs feedback
  • % Done changed from 0 to 90

Images are now available for connector types in production profile, css is used now.

Commit:
https://github.com/bcvsolutions/CzechIdMng/commit/a765479851321471d3428af1b78d82addff029f9

Could you provide me a feedback, please?

Note: Refactoring can be moved into some 10.7.x version after feedback, if needed.
Note: Icon size property moved into basic icon (=> example content with registered icons is ok now)
Note: Icon are still placed in core theme (#2621), so icons will not work, when different theme is enabled => copy connector icons to your theme as workaround, if needed.

Actions
Copy link
 #6

Updated by Vít Švanda almost 4 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Vít Švanda to Radek Tomiška

I did review and tested it. This was my fault, I didn't realized, that dist folder is not use in all profiles. Thanks for this fix. Definitialy this shoud be part of next hotfix, because without images is connector page very ugly :-) .

Actions
Copy link
 #7

Updated by Radek Tomiška almost 4 years ago

  • Status changed from Resolved to Closed
  • Target version changed from 10.8.0 to 10.7.1
  • % Done changed from 90 to 100

Moved into version 10.7.1, version released:
https://github.com/bcvsolutions/CzechIdMng/releases/tag/10.7.1

Actions
Copy link
 #8

Updated by Radek Tomiška almost 4 years ago

  • Related to Defect #2631: CSV wizard - missing IdM logo added
Actions
Copy link

Also available in: Atom PDF