Project

General

Profile

Actions

Task #2528

closed

Wizard - Implement connector templates.

Added by Vít Švanda over 3 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Vít Švanda
Category:
Wizard
Target version:
Start date:
10/21/2020
Due date:
% Done:

100%

Estimated time:
Owner:

Description

The aim is to offer the user pre-filled variants of connectors. Prefill will be dynamic.

For example: Table connectors will be offered according to the available drivers. The CSV connector will suggest a specific path where to insert the file (or display a dropzone).

Connector templates = connector definition + metadata.

List of templates will new step (0) in the system wizard.


Related issues

Related to IdStory Identity Manager - Defect #2620: Wizard: missing conntector imagesClosedRadek Tomiška12/18/2020

Actions
Actions #1

Updated by Vít Švanda over 3 years ago

  • Status changed from New to Resolved
Actions #2

Updated by Vít Švanda over 3 years ago

  • Status changed from Resolved to In Progress
Actions #3

Updated by Vít Švanda over 3 years ago

  • % Done changed from 0 to 50
Actions #4

Updated by Vít Švanda over 3 years ago

  • % Done changed from 50 to 60
Actions #5

Updated by Vít Švanda over 3 years ago

  • % Done changed from 60 to 70
Actions #6

Updated by Vít Švanda over 3 years ago

  • Category changed from Connectors to Wizard
Actions #7

Updated by Vít Švanda over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška
  • % Done changed from 70 to 90

Feature was implemented. Tests were created too. All is in the develop now.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/fb6d2d9e33a92f54fb2874f9d7795ace867889e9

Actions #8

Updated by Radek Tomiška over 3 years ago

  • Status changed from Needs feedback to In Progress
  • Assignee changed from Radek Tomiška to Vít Švanda

I did test and code review, feature is really complex, i like it. Content with available connectors (flex box) is awesome!

I have some notes from testing:
- I have existing AD system configured - open in wizard - blank page is shown after "schema" step ("Uncaught TypeError: this.state.connectorType is undefined"). The same for VS systems.
- Navigation key is missing on url 'http://localhost:3000/#/connector-types' => 'Dashboard' title is shown
- create new VS system - go to "atributes" step => go back => go next - null pointer "at eu.bcvsolutions.idm.acc.connector.AbstractConnectorType.executeMappingStep(AbstractConnectorType.java:220)". This can be reproducd on AD system to => maybe is connected with manually created schema, I don't know.

And some optional notes :)
- I have existing VS system configured and and deleted identity, which is configured as realizator - second step cannot be shown (validation occurs, even realizators are not shown)
- additional connector setting has to be saved separately (standalone save button), i think i will be confusing for someone :)
- public constant in AbstractConnectorType can be moved to interface
- I don't use protectedservices personally - it complicate future refactoring :)
- ConnectorType#getIconKey could return whole icon value (=> ConnectorType#getIcon() { return "component:connector-one" }) => default "fa:" or "glyphicon:" library can be used, when custom conntector type will be register and no FE icon implementation is needed (+ posible configurable api in future, see ConfigurationService#PROPERTY_ICON usage). This requires icon styling will be outside too (but icon can be used through whole app e.g. modal headers).
- we need to change icon for automatic roles
- new property "classNameTable" should be removed and standard "className" property should be used as ".basic-table .table-cell-vertical-middle-align table { ... }"
- ShortText.js - Tooltip was removed, why :)?

Actions #9

Updated by Vít Švanda over 3 years ago

  • Status changed from In Progress to Needs feedback
  • Assignee changed from Vít Švanda to Radek Tomiška

Thanks for good testing. I fixed big issues and ✌some notes.

Commit: https://github.com/bcvsolutions/CzechIdMng/commit/e1402beb973fa618667e693ce93dc2be641362b8

- ✔ I have existing AD system configured - open in wizard - blank page is shown after "schema" step ("Uncaught TypeError: this.state.connectorType is undefined"). The same for VS systems.
- ✔_Navigation key is missing on url 'http://localhost:3000/#/connector-types' => 'Dashboard' title is shown_
- ✔_create new VS system - go to "atributes" step => go back => go next - null pointer "at eu.bcvsolutions.idm.acc.connector.AbstractConnectorType.executeMappingStep(AbstractConnectorType.java:220)". This can be reproducd on AD system to => maybe is connected with manually created schema, I don't know._

- ❌ I have existing VS system configured and and deleted identity, which is configured as realizator - second step cannot be shown (validation occurs, even realizators are not shown). The validation is performed on system save. I am not easily able to solve this (I can skip a validation on system save, but I don't want it).
- additional connector setting has to be saved separately (standalone save button), i think i will be confusing for someone :)
- ✔ public constant in AbstractConnectorType can be moved to interface
- ✔_I don't use protectedservices personally - it complicate future refactoring :)_
- ConnectorType#getIconKey could return whole icon value (=> ConnectorType#getIcon() { return "component:connector-one" }) => default "fa:" or "glyphicon:" library can be used, when custom conntector type will be register and no FE icon implementation is needed (+ posible configurable api in future, see ConfigurationService#PROPERTY_ICON usage). This requires icon styling will be outside too (but icon can be used through whole app e.g. modal headers).
- we need to change icon for automatic roles
- new property "classNameTable" should be removed and standard "className" property should be used as ".basic-table .table-cell-vertical-middle-align table { ... }"
- ShortText.js - Tooltip was removed, why :)? A Fulltext title was shorted in the tooltip for my case.

Actions #10

Updated by Radek Tomiška over 3 years ago

  • Status changed from Needs feedback to Resolved
  • Assignee changed from Radek Tomiška to Vít Švanda
  • % Done changed from 90 to 100

I did test and code review, it's awesome, thx!

Actions #11

Updated by Radek Tomiška over 3 years ago

  • Status changed from Resolved to Closed
Actions #12

Updated by Radek Tomiška over 3 years ago

  • Related to Defect #2620: Wizard: missing conntector images added
Actions

Also available in: Atom PDF